Finished Fifo API to track and retrieve item count from fifo queue#204
Open
Arcmantis18 wants to merge 1 commit intomypaint:masterfrom
Open
Finished Fifo API to track and retrieve item count from fifo queue#204Arcmantis18 wants to merge 1 commit intomypaint:masterfrom
Arcmantis18 wants to merge 1 commit intomypaint:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Going through the codebase I noticed that though fifo_pop decremented item_count when popping an item, fifo_push did not increment the item_count for every item stored in the queue. I added this and provided an interface to retrieve the item count from the queue.
This is useful for analytics and benchmarking.
Thank you,
Arcmantis