Allow building mysqlclient without server deps#680
Open
BlackDex wants to merge 1 commit into
Open
Conversation
Currently when I only want to build the mysqlclient library I'm forced to also provide the ncurses/readline and rpc, but the client does not need those. With these changes will check if the `WITHOUT_SERVER` flag is set and skip those checks. Building the client still works this way. Signed-off-by: BlackDex <black.dex@gmail.com>
BlackDex
force-pushed
the
allow-building-libmysqclient-only
branch
from
d7a5b96 to
f441cfa
Compare
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
Author
|
@mysql-oca-bot I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when I only want to build the mysqlclient library I'm forced to also provide the ncurses/readline and rpc, but the client does not need those.
With these changes will check if the
WITHOUT_SERVERflag is set and skip those checks. Building the client still works this way.I'm not sure if this might have other implications though with other parts of libraries able to build this way, but I think this should be fine.