Skip to content

Renovate mynordic-oauth-test app#5

Open
jfManuel040790 wants to merge 1 commit into
nRFCloud:mainfrom
jfManuel040790:renovate/mynordic-oauth-test
Open

Renovate mynordic-oauth-test app#5
jfManuel040790 wants to merge 1 commit into
nRFCloud:mainfrom
jfManuel040790:renovate/mynordic-oauth-test

Conversation

@jfManuel040790

Copy link
Copy Markdown

Implement silent SSO in test app

@coderbyheart coderbyheart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • do not add compiled artifacts to the repo, ignore the dist folder
  • There are now two apps, one in the root, and one in mynordic, please combine them into one.
  • Please provide instructions on how to test the flow using your changes. When I run the app using npx vite I get this error:
➜ npx vite

  VITE v8.0.1  ready in 149 ms

  ➜  Local:   http://localhost:8080/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
(!) Failed to run dependency scan. Skipping dependency pre-bundling. Error:   Failed to scan for dependencies from entries:
  /home/m/nrfcloud/myNordic-test-spa/index.html
/home/m/nrfcloud/myNordic-test-spa/mynordic-oauth-test/index.html
/home/m/nrfcloud/myNordic-test-spa/mynordic-oauth-test/mynordic/sso.html
/home/m/nrfcloud/myNordic-test-spa/mynordic-oauth-test/mynordic/from-portal/index.html

  Build failed with 1 error:

[plugin vite:dep-scan:resolve]
Error: "./redirect-bridge" is not exported under the conditions ["module", "browser", "development", "import"] from package /home/m/nrfcloud/myNordic-test-spa/node_modules/@azure/msal-browser (see exports field in /home/m/nrfcloud/myNordic-test-spa/node_modules/@azure/msal-browser/package.json)
    at async EnvironmentPluginContainer.resolveId (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/vite/dist/node/chunks/node.js:29939:19)
    at async resolve (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/vite/dist/node/chunks/node.js:30618:16)
    at async PluginContextImpl.resolveId (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/vite/dist/node/chunks/node.js:30748:23)
    at async plugin (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/rolldown/dist/shared/bindingify-input-options-DoaqRULI.mjs:1018:16)
    at async plugin.<computed> (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/rolldown/dist/shared/bindingify-input-options-DoaqRULI.mjs:1575:12)
    at aggregateBindingErrorsIntoJsError (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/rolldown/dist/shared/error-BO4SlZV_.mjs:48:18)
    at unwrapBindingResult (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/rolldown/dist/shared/error-BO4SlZV_.mjs:18:128)
    at scan (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/rolldown/dist/experimental-index.mjs:176:3)
    at async Object.build (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/vite/dist/node/chunks/node.js:30573:3)
    at async scan (file:///home/m/nrfcloud/myNordic-test-spa/node_modules/vite/dist/node/chunks/node.js:30518:4)
    at async file:///home/m/nrfcloud/myNordic-test-spa/node_modules/vite/dist/node/chunks/node.js:23088:15

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not commit secrets to source code. Add .envrc to your global gitignore file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants