Skip to content

chore(python): avoid using type(self) in protocols #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcoGorelli wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

chore(python): avoid using type(self) in protocols #3479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions narwhals/_compliant/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ def func(df: EagerDataFrameT) -> list[EagerSeriesT]:
results.append(result)
return results

return type(self)(
return self.__class__(
func,
evaluate_output_names=self._evaluate_output_names,
alias_output_names=self._alias_output_names,
Expand Down Expand Up @@ -647,7 +647,7 @@ def alias_output_names(names: Sequence[str]) -> Sequence[str]:
raise MultiOutputExpressionError(msg)
return [name]

return type(self)(
return self.__class__(
lambda df: [series.alias(name) for series in self(df)],
evaluate_output_names=self._evaluate_output_names,
alias_output_names=alias_output_names,
Expand Down
2 changes: 1 addition & 1 deletion narwhals/_sql/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def _with_alias_output_names(self, func: AliasNames | None, /) -> Self:
if current_alias_output_names is None
else lambda output_names: func(current_alias_output_names(output_names))
)
return type(self)(
return self.__class__(
self._call,
self._window_function,
evaluate_output_names=self._evaluate_output_names,
Expand Down
Loading