chore: Remove level from main and v2 classes init#3558
Open
chore: Remove level from main and v2 classes init#3558
level from main and v2 classes init#3558Conversation
FBruzzesi
commented
Apr 19, 2026
|
|
||
| def inherit_doc( | ||
| tp_parent: Callable[P, R1], / | ||
| tp_parent: Callable[..., R1], / |
Member
Author
There was a problem hiding this comment.
@dangotbanned you might have a better way of doing this but here what happened - by changing the main namespace __init__ signatures, now the V1 is overriding them and the arguments are different, to so the child ones are not bind to the parent ones - hence removing the P from the parent here.
This meant that return DataFrame(self, level="interchange") was resulting in a typing issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Not really user facing but I had it started some time ago, so why not finish it 😇
What type of PR is this? (check all applicable)
Related issues
level,DataFrameLikefrommain,v2#2932Checklist