chore(python): pin pyarrow version in typing job, adjust tests for pyarrow 24#3561
Open
MarcoGorelli wants to merge 2 commits intonarwhals-dev:mainfrom
Open
chore(python): pin pyarrow version in typing job, adjust tests for pyarrow 24#3561MarcoGorelli wants to merge 2 commits intonarwhals-dev:mainfrom
MarcoGorelli wants to merge 2 commits intonarwhals-dev:mainfrom
Conversation
MarcoGorelli
force-pushed
the
pin-pyarrow-typing
branch
from
23de15f to
5187052
Compare
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
pin-pyarrow-typing
branch
2 times, most recently
from
4d03218 to
e0aa8a4
Compare
MarcoGorelli
force-pushed
the
pin-pyarrow-typing
branch
from
e0aa8a4 to
0192b71
Compare
MarcoGorelli
commented
Apr 21, 2026
Comment on lines
-220
to
-222
| request.applymarker( | ||
| pytest.mark.xfail(is_pyarrow_windows_no_tzdata(constructor), reason="no tzdata") | ||
| ) |
Member
Author
There was a problem hiding this comment.
looks like the "tzdata" thing is pyarrow-version dependent
we're already running these tests on linux
IMO we can just skip, it's not our responsibility to tests whether pyarrow runs the same way on windows and linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
temp solution to #3560 to get CI green
Description
What type of PR is this? (check all applicable)
Related issues
Checklist