Core: remove the commit fee clamp, add max fee#29
Open
aarani wants to merge 3 commits intonblockchain:geewalletLightningMilestone12from
Open
Core: remove the commit fee clamp, add max fee#29aarani wants to merge 3 commits intonblockchain:geewalletLightningMilestone12from
aarani wants to merge 3 commits intonblockchain:geewalletLightningMilestone12from
Conversation
aarani
force-pushed
the
fixFeeCalculation
branch
3 times, most recently
from
6b4bb58 to
5668284
Compare
This commit fixes the issue caused by YoloDev.Expecto.TestSdk upgrade to netcoreapp3.1.
Since compiler sometimes complains that it doesn't know which overload to use. Instead we just prepare constructors for each integral types. Might be related to dotnet/fsharp#1565
This commit removes the check that compares mutual close fee with commit tx fee, this check is outdated and has been changed by this spec PR [1]. To prevent unreasonably high fee, this commit introduces MutualCloseMaxFeeMultiplier setting. [1] lightning/bolts#847
aarani
force-pushed
the
fixFeeCalculation
branch
from
9e2eee5 to
7e2e657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the check that compares mutual close fee with commit tx fee, this check is outdated and has been changed by this spec PR [1].
To prevent unreasonably high fee, this commit introduces MutualCloseMaxFeeMultiplier setting.
[1] lightning/bolts#847