Skip to content

Staging #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncdai merged 2 commits into from
Jun 30, 2026
Merged

Staging #1304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43ea242
refactor(experiences): remove generic soft skills from experience
ncdai Jun 30, 2026
e74871b
feat(social-links): display social media handle in tooltip
ncdai Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/features/portfolio/components/social-links.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ export function SocialLinks() {
/>
}
/>
<TooltipContent>{item.title}</TooltipContent>
<TooltipContent>
{item.title} ({item.handle})
</TooltipContent>
</Tooltip>
</li>
))}
Expand Down
5 changes: 4 additions & 1 deletion src/features/portfolio/components/testimonials.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
} from "@/registry/transformed/components/testimonial"
import { TestimonialSpotlight } from "@/registry/transformed/components/testimonial-spotlight"
import { Twemoji } from "@/registry/transformed/components/twemoji/twemoji"
import { SOCIAL } from "@/features/portfolio/data/social-links"
import {
TESTIMONIALS_1,
TESTIMONIALS_2,
Expand Down Expand Up @@ -66,7 +67,9 @@ export function Testimonials() {
<PanelTitle>
Trusted by
<span className="block sm:hidden" /> top builders on{" "}
<span aria-label="X">𝕏</span>
<a href={SOCIAL.x.href} target="_blank" rel="noopener" aria-label="X">
𝕏
</a>
</PanelTitle>
</PanelHeader>

Expand Down
18 changes: 2 additions & 16 deletions src/features/portfolio/data/experiences.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const EXPERIENCES: Experience[] = [
"Figma",
"Polar",
"Storybook",
"UI/UX Design",
"Design",
],
isExpanded: true,
},
Expand Down Expand Up @@ -87,7 +87,6 @@ In-house Project: [ZaDark](https://zadark.com)
"Design System",
"Brand Design",
"Figma",
"Research",
],
},
{
Expand Down Expand Up @@ -138,9 +137,6 @@ In-house Project: [ZaDark](https://zadark.com)
"Dify",
"Zalo Mini App",
"Agile",
"Teamwork",
"Research",
"Problem-solving",
],
},
{
Expand Down Expand Up @@ -178,15 +174,7 @@ In-house Project: [ZaDark](https://zadark.com)
- Built a complex rich-text editor based on ProseMirror and Slate for customizable content creation.
- Integrated APIs with the Backend Team to enhance functionality.`,
icon: <CodeXmlIcon />,
skills: [
"React",
"Redux",
"Storybook",
"Lerna",
"Agile",
"Teamwork",
"Research",
],
skills: ["React", "Redux", "Storybook", "Lerna", "Agile"],
},
{
id: "2",
Expand All @@ -209,8 +197,6 @@ In-house Project: [ZaDark](https://zadark.com)
"Google Play Store",
"App Center",
"Agile",
"Teamwork",
"Research",
],
},
{
Expand Down