Skip to content

Add GPU quota to default quotas registration #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knikolla wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add GPU quota to default quotas registration #295

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cf203e
Add GPU quota to default quotas registration
knikolla Mar 10, 2026
dd0ad6a
Update src/coldfront_plugin_cloud/management/commands/register_defaul…
knikolla Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/coldfront_plugin_cloud/management/commands/register_default_quotas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ def handle(self, *args, **options):
"resource_type": STORAGE_RESOURCE_TYPE_NAME,
"invoice_name": OPENSTACK_STORAGE_INVOICE_NAME,
},
{
"display_name": attributes.QUOTA_GPU,
"quota_label": "internal.gpu_quota",
Comment thread
knikolla marked this conversation as resolved.
Outdated
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new quota entry omits fields (e.g. multiplier, static_quota, unit_suffix) that every other default quota passes through to add_quota_to_resource. For consistency and to avoid depending on implicit defaults/CLI optionality, set them explicitly (likely multiplier: 0, static_quota: 0, unit_suffix: ""). Also, the unit test for register_default_quotas asserts the exact set of OpenStack default quota keys and will need to include attributes.QUOTA_GPU once this is added.

Suggested change
"quota_label": "internal.gpu_quota",
"quota_label": "internal.gpu_quota",
"multiplier": 0,
"static_quota": 0,
"unit_suffix": "",

Copilot uses AI. Check for mistakes.
},
]

# Find OpenShift resources
Expand Down
Loading