feat(packages/graphql): resolve field output type by name#3932
Open
NicolasGn wants to merge 1 commit intonestjs:masterfrom
Open
feat(packages/graphql): resolve field output type by name#3932NicolasGn wants to merge 1 commit intonestjs:masterfrom
NicolasGn wants to merge 1 commit intonestjs:masterfrom
Conversation
Contributor
Author
|
I'm not sure of where I should write the test for this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In a code-first schema definition, we need to import the type of any object field.
This behavior can lead NodeJS module circular import issue because GraphQL philosophy allows (and even encourage in complex schemas) cyclic relations.
Here is tiny project illustrating the problem with a very simple 3 types schema, using a classical GraphQL pattern: https://github.com/NicolasGn/nestjs-graphql-circluar-dependency
What is the new behavior?
To break the circular import, we need to be able to reference a schema type by its name and not exclusively by a type reference.
Does this PR introduce a breaking change?
Other information