Skip to content

fix: handle optional dependencies/devDependencies in package.json parsing #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kamilmysliwiec merged 2 commits into from
Mar 11, 2026
Merged

fix: handle optional dependencies/devDependencies in package.json parsing #3282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c64b6
Initial plan
Copilot Mar 11, 2026
d3044aa
fix: handle optional dependencies fields in package.json parsing
Copilot Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/package-managers/abstract.package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export abstract class AbstractPackageManager {
public async getProduction(): Promise<ProjectDependency[]> {
const packageJsonContent = await this.readPackageJson();
const packageJsonDependencies: Record<string, string> =
packageJsonContent.dependencies;
packageJsonContent.dependencies ?? {};
const dependencies = [];

for (const [name, version] of Object.entries(packageJsonDependencies)) {
Expand All @@ -110,7 +110,7 @@ export abstract class AbstractPackageManager {
public async getDevelopment(): Promise<ProjectDependency[]> {
const packageJsonContent = await this.readPackageJson();
const packageJsonDevDependencies: Record<string, string> =
packageJsonContent.devDependencies;
packageJsonContent.devDependencies ?? {};
const dependencies = [];

for (const [name, version] of Object.entries(packageJsonDevDependencies)) {
Expand All @@ -121,8 +121,8 @@ export abstract class AbstractPackageManager {
}

private async readPackageJson(): Promise<{
dependencies: Record<string, string>;
devDependencies: Record<string, string>;
dependencies?: Record<string, string>;
devDependencies?: Record<string, string>;
}> {
const buffer = await readFile(join(process.cwd(), 'package.json'));
return JSON.parse(buffer.toString());
Expand Down
Loading