Skip to content

fix: support CLI rspackPath override in getRspackConfigPath#3283

Merged
kamilmysliwiec merged 2 commits intov12.0.0from
copilot/sub-pr-3280-again
Mar 11, 2026
Merged

fix: support CLI rspackPath override in getRspackConfigPath#3283
kamilmysliwiec merged 2 commits intov12.0.0from
copilot/sub-pr-3280-again

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 11, 2026

cmdOptions was accepted as a parameter in getRspackConfigPath but never used, triggering @typescript-eslint/no-unused-vars warnings and leaving CLI override support unimplemented.

Changes

  • get-rspack-config-path.ts: Check cmdOptions.rspackPath before falling back to the builder configuration, mirroring the pattern already used in getWebpackConfigPath
  • get-rspack-config-path.spec.ts: Add test covering the CLI override precedence
// CLI rspackPath now takes precedence over nest-cli.json builder config
const rspackPath =
  getRspackConfigPath(configuration, { rspackPath: 'custom.rspack.config.ts' }, appName);
// → 'custom.rspack.config.ts'

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: kamilmysliwiec <23244943+kamilmysliwiec@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from review on v12.0.0 major release fix: support CLI rspackPath override in getRspackConfigPath Mar 11, 2026
@kamilmysliwiec kamilmysliwiec marked this pull request as ready for review March 11, 2026 14:59
@kamilmysliwiec kamilmysliwiec merged commit b0ae68c into v12.0.0 Mar 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants