refactor(schematics): update eslint config for TypeScript template - #2339
Closed
yousefdawood7 wants to merge 3 commits into
Closed
refactor(schematics): update eslint config for TypeScript template#2339yousefdawood7 wants to merge 3 commits into
yousefdawood7 wants to merge 3 commits into
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The generated ESLint configuration uses
eslint.config.mjsbut wraps configuration usingtseslint.config(...), which is no longer necessary with the current flat config approach.Additionally, the generated
tsconfig.jsonincludesbaseUrl, which is discouraged in newer TypeScript setups and can lead to confusion when not required.What is the new behavior?
tseslint.config(...)wrapper and usingdefineConfigdirectlyeslint.config.mjsformat aligned with modern flat config usagebaseUrlfromtsconfig.jsonto align with current TypeScript recommendations and reduce unnecessary configurationDoes this PR introduce a breaking change?
Other information