feat(schematics): support skipping application testing scaffold - #2354
Open
yudin-s wants to merge 1 commit into
Open
feat(schematics): support skipping application testing scaffold#2354yudin-s wants to merge 1 commit into
yudin-s wants to merge 1 commit into
Conversation
3 tasks
yudin-s
force-pushed
the
fix/application-skip-testing
branch
from
May 27, 2026 08:08
3455e43 to
df4c7f7
Compare
yudin-s
force-pushed
the
fix/application-skip-testing
branch
from
June 11, 2026 13:59
df4c7f7 to
1d35597
Compare
Member
|
since we will switch to Vitest in Nestjs v12, I think it would be better to move this change for v12 instead of introducing it in v11. To be really honest, I don't think we should support skipping test generation on scaffolding. The projects should have some sort of automated tests. If you really want to remove them, you can easily refactor it later with LLMs. |
yudin-s
force-pushed
the
fix/application-skip-testing
branch
from
June 12, 2026 02:05
1d35597 to
adc5a00
Compare
Contributor
Author
|
Retargeted this PR to While resolving the v12 rebase, I kept the v12 Vitest/oxlint scaffold and adapted Local checks passed:
CircleCI is running on the updated head now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The application schematic can skip generated spec files with
spec: false, but there is no way for callers to request a project without the full testing scaffold. The generated project still includes e2e test files, Jest scripts/configuration, and Jest/Supertest-related dev dependencies.Issue Number: Refs nestjs/nest-cli#2575
What is the new behavior?
Adds a
skipTestingapplication schematic option. When enabled, TypeScript and JavaScript application projects are generated without unit/e2e test files, testing scripts, Jest configuration, or Jest/Supertest-related dev dependencies.This keeps the existing
spec: falsebehavior intact for callers that only want to skip spec files.Does this PR introduce a breaking change?
Other information
Validated with:
npm run lintcurrently reports pre-existing errors in unrelated files, so the validation above scopes linting to the changed TypeScript sources.