Add recipe/recipe.yaml to bumpversion (#377) - #395
Open
marouenbg wants to merge 1 commit into
Open
Conversation
All three conda workflows build with rattler-build from recipe/, so recipe/recipe.yaml is the recipe that actually ships, but it was not listed in .bumpversion.cfg. Bumps updated the legacy, unused conda/meta.yaml and skipped the live recipe, which is why the 0.11.0 bump had to be patched by hand. Fixes netZoo#377 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #377.
Problem
The issue asked to add the conda recipe to
.bumpversion.cfg. The snippet in the issue body (conda/meta.yaml) had already been applied — but that file is the legacy conda-build recipe and nothing uses it. All three conda workflows (test-conda-build,conda-publish,conda-publish-manual) build withrattler-buildfromrecipe-path: recipe/, sorecipe/recipe.yamlis the recipe that actually ships, and it was not in the bumpversion config.Result: every version bump updated the dead file and skipped the live one. That's exactly what happened on 2026-01-09 — the
0.10.9 → 0.11.0bump missedrecipe/recipe.yaml, it was patched by hand ("Update recipe.yaml"), and this issue was filed the same day.Change
One line in
.bumpversion.cfg:Verification
bumpversion patch --dry-runasserts all six target files contain the version string and would stagerecipe/recipe.yaml.recipe/recipe.yamlwentversion: "0.11.0"→version: "0.11.1"with its quotes preserved.Follow-up (not in this PR)
The
conda/directory (meta.yaml+conda_build_config.yamlpinning Python 3.7–3.10) is dead — no workflow, doc, or file references it. Worth deleting along with its bumpversion entry in a separate cleanup.🤖 Generated with Claude Code