Add support for managing NetBox event rules#1434
Open
chris-cald wants to merge 4 commits into
Open
Conversation
Author
|
Can anyone give pointers on why unit tests are failing in areas I didn't touch? Having similar problem with all tests failing locally even on a fresh clone. Seems like they are broken in the repo. |
Contributor
|
@squirrel289 Hi, the latest commits in devel should resolve those issues, please update your branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#1261
New Behavior
Added Tasks for managing Event Rules
...
Contrast to Current Behavior
Currently can not manage Event Rules
...
Discussion: Benefits and Drawbacks
Adds ability to manage Netbox event rules through Ansible. Net-new functionality so no risk to backwards compatibility. The support for
conditionsproperty required an inelegant approach as I couldn't figure out how to safely modify the existingserializefunctionality...
Changes to the Documentation
Added doc for event_rules module
...
Proposed Release Note Entry
Add support for managing NetBox event rules
...
Double Check
develbranch.