Standardise MikroTik QSFP naming#3957
Open
grische wants to merge 1 commit into
Open
Conversation
Collaborator
|
This would not correctly represent these devices. There are only 2 physical QSFP+ cages on the devices. We only want to represent 2 interfaces in the template. The addition of "-1" matches the name used on the command line. The other items are not real ports and should probably be represented as the virtual type - or left out of the template. |
Contributor
Author
|
@grbeneke if this is the case, then someone needs to adjust all other 6 mentioned devices. This PR here is merely to make the 3 in this PR consistent to the other 6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MikroTik switches the QSFP ports are always defined as 4 different ports. When a QSFP module without breakouts is being used, only the
-1is being active, all other dormant. If breakouts are being used, all others are also active.This PR changes to reflect the correct interface naming in the RouterOS commandline, making it the same as as many other MikroTik switches:
Here's an example output: