Add BANNER_MAINTENANCE environment variable to set the Maintenance Banner#1699
Open
sweickge wants to merge 1 commit into
Open
Add BANNER_MAINTENANCE environment variable to set the Maintenance Banner#1699sweickge wants to merge 1 commit into
sweickge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmitting new PR because of branch issue
New Behavior
Add environment variable (BANNER_MAINTENANCE) to be able to set a custom Maintenance Banner in the docker compose override file
This parameter is described in the Netbox documentation: https://netboxlabs.com/docs/netbox/configuration/miscellaneous/#banner_maintenance
Contrast to Current Behavior
Right now, this can not be set as an env var
Discussion: Benefits and Drawbacks
Right now, the only way to set this would be defining the variable in configuration/extra.py, which would require a rebuild of the netbox-docker image anytime it is changed. An env variable would make it easier to change. This is similar to how how other banner variables are currently defined e.g BANNER_TOP and BANNER_BOTTOM.
If approved, I would like to see this change backported as well to a 4.0.X release since that still supports Netbox 4.5.X if that is possible. As 4.6 is still new, we are unable to upgrade at this time. This change would be backwards compatible to any Netbox release that has the BANNER_MAINTENANCE parameter.
Changes to the Wiki
N/A
Proposed Release Note Entry
Enable setting BANNER_MAINTENANCE parameter as an environment variable
Double Check
developbranch.