Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions netbox/extras/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,9 @@ def _get_url(self, action, instance=None):
def test_list_objects_anonymous(self):
return

def test_export_objects_anonymous(self):
return

def test_list_objects_with_constrained_permission(self):
return

Expand Down Expand Up @@ -962,6 +965,9 @@ def test_list_objects_anonymous(self):
login_url = reverse('login')
self.assertRedirects(self.client.get(url), f'{login_url}?next={url}')

def test_export_objects_anonymous(self):
return

def test_list_objects_with_permission(self):
return

Expand Down Expand Up @@ -1070,6 +1076,9 @@ def test_list_objects_anonymous(self):
login_url = reverse('login')
self.assertRedirects(self.client.get(url), f'{login_url}?next={url}')

def test_export_objects_anonymous(self):
return

def test_list_objects_with_permission(self):
return

Expand Down
4 changes: 2 additions & 2 deletions netbox/netbox/views/generic/bulk_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def get(self, request):
if request.GET['export'] == 'table':
table = self.get_table(self.queryset, request, has_table_actions)
columns = [name for name, _ in table.selected_columns]
delimiter = request.user.config.get('csv_delimiter')
delimiter = request.user.config.get('csv_delimiter') if request.user.is_authenticated else None
return self.export_table(table, columns, delimiter=delimiter)

# Render an ExportTemplate
Expand All @@ -202,7 +202,7 @@ def get(self, request):

# Fall back to default table/YAML export
table = self.get_table(self.queryset, request, has_table_actions)
delimiter = request.user.config.get('csv_delimiter')
delimiter = request.user.config.get('csv_delimiter') if request.user.is_authenticated else None
return self.export_table(table, delimiter=delimiter)

# Render the objects table
Expand Down
25 changes: 25 additions & 0 deletions netbox/utilities/testing/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,31 @@ def test_export_objects(self):
self.assertHttpStatus(response, 200)
self.assertEqual(response.get('Content-Type'), 'text/csv; charset=utf-8')

@override_settings(EXEMPT_VIEW_PERMISSIONS=['*'], LOGIN_REQUIRED=False)
def test_export_objects_anonymous(self):
# Ensure we are logged out.
self.client.logout()

# Some models (e.g. the users model) always require to be logged in, so we skip them here.
ct = ContentType.objects.get_for_model(self.model)
if (ct.app_label, ct.model) in settings.EXEMPT_EXCLUDE_MODELS:
return

url = self._get_url('list')

# Test default CSV (or sometimes YAML) export
response = self.client.get(f'{url}?export')
self.assertHttpStatus(response, 200)
if hasattr(self.model, 'to_yaml'):
self.assertEqual(response.get('Content-Type'), 'text/yaml')
else:
self.assertEqual(response.get('Content-Type'), 'text/csv; charset=utf-8')

# Test table-based export
response = self.client.get(f'{url}?export=table')
self.assertHttpStatus(response, 200)
self.assertEqual(response.get('Content-Type'), 'text/csv; charset=utf-8')

class CreateMultipleObjectsViewTestCase(ModelViewTestCase):
"""
Create multiple instances using a single form. Expects the creation of three new instances by default.
Expand Down