feat(device-discovery): vrf discovery for huawei_vrp, hp_comware, cumulus_linux, dell_sonic

[leoparente]

Summary

Second custom-driver batch implementing get_network_instances() for VRF discovery (follows #452 / #453). All four return the NAPALM OpenConfig network-instances shape consumed by options.discover_vrfs.

Per driver

Driver	Data source	Notes
huawei_vrp	display ip vpn-instance interface (ntc-template) + summary	RDs parsed driver-locally — the summary ntc-template requires an RD on every row and error-exits on RD-less instances. The AF column prints ipv4-family on some releases and plain IPv4/IPv6 on others (the ntc real-device fixture uses the latter); both anchor the row, and per-AF rows merge keeping the first non-empty RD.
hp_comware	display ip vpn-instance (ntc-template) + per-instance detail	Detail parsed driver-locally — the detail ntc-template error-exits on routine lines it doesn't enumerate (e.g. "Route & Tunnel selection time"). Wrapped, multi-member-per-line interface lists handled.
cumulus_linux	ip vrf show (linux ntc-template) + per-VRF ip link show master	Kernel @parent decorations stripped to match get_interfaces() naming. Linux VRFs carry no kernel-level RD (it lives in FRR BGP) — always emitted absent.
dell_sonic	show vrf, driver-local parse	Routed through the file's CLI-error-banner guard so an unsupported command can't become a junk VRF; continuation rows, comma-separated member cells, and a VRF literally named Vrf all handled. mgmt is kept as a real VRF.

Common semantics (matching batches 1): seeded DEFAULT_INSTANCE with empty membership, rows named default can never overwrite the seed, NAPALM name filter honored on every path, member names match each driver's own get_interfaces()/get_interfaces_ip() naming so VRF→IP attachment joins correctly.

Also documents get_network_instances in the custom-driver guide (custom_napalm/CLAUDE.md): output shape, the six batch conventions, and a validation-checklist entry.

Tests

• 11 fixture scenarios across the four drivers, including the real-device output variants that broke earlier parser drafts (huawei IPv4 AF column, SONiC error banner, comware multi-member wrap)
• Driver ownership pin matrix extended to 13 drivers
• Full suite: 1758 passed, 170 skipped; ruff clean

Review trail

Two adversarial Claude review rounds: round 1 found two verified majors (huawei RD regex missing the plain-IPv4 AF column form seen in ntc-templates' own real-device fixture; SONiC error banner ingested as a VRF named %) plus two minors — all fixed with pinning fixtures; round 2: APPROVED.

🤖 Generated with Claude Code

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
device_discovery
client.py	66	10	85%	169–188
discovery.py	76	5	93%	102–104, 174–177
entity_metadata.py	13	2	85%	24, 27
interface.py	217	5	98%	141–145, 491–492
main.py	49	2	96%	182, 188
metrics.py	53	1	98%	133
server.py	88	10	89%	44–46, 72–87, 184, 187
stubs.py	160	10	94%	31, 64, 84, 146, 256, 301, 324–329, 341–346
translate.py	283	7	98%	141, 143, 256, 478, 556, 567, 608
translate_chassis.py	175	6	97%	42, 45, 54–55, 149, 405
translate_modules.py	107	1	99%	217
version.py	7	1	86%	14
vrf.py	72	3	96%	67–68, 99
device_discovery/policy
manager.py	61	3	95%	37–38, 161
portscan.py	84	11	87%	34–35, 59–60, 64, 72–76, 117
run.py	88	2	98%	158, 193
runner.py	253	23	91%	276–280, 285–286, 303–304, 397, 631, 650–682
TOTAL	1988	102	95%

Tests	Skipped	Failures	Errors	Time
1928	170 💤	0 ❌	0 🔥	18.988s ⏱️

[Copilot]

Pull request overview

Implements VRF discovery for four additional custom NAPALM drivers by adding get_network_instances() implementations that return the OpenConfig network-instances shape consumed by options.discover_vrfs, along with fixtures, dispatch-matrix pinning, and contributor documentation updates.

Changes:

• Add get_network_instances() to huawei_vrp, hp_comware, cumulus_linux, and dell_sonic custom drivers with platform-specific parsing/guarding.
• Extend VRF-dispatch ownership pin matrix to include the four new drivers.
• Add/extend test_get_network_instances fixture scenarios for the four drivers and document the expected getter shape + conventions in custom_napalm/CLAUDE.md.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
device-discovery/tests/test_runner_vrf_dispatch.py	Pins VRF discovery support matrix to include the four added custom drivers.
device-discovery/custom_napalm/huawei_vrp.py	Adds VRP VPN-instance → OC network-instances VRF discovery (summary RD regex + interface membership via ntc-template).
device-discovery/custom_napalm/hp_comware.py	Adds Comware VPN-instance → OC network-instances VRF discovery (detail parsed driver-locally for RD + interfaces).
device-discovery/custom_napalm/cumulus_linux.py	Adds Linux VRF device → OC network-instances discovery via ip vrf show + ip link show master.
device-discovery/custom_napalm/dell_sonic.py	Adds SONiC VRF discovery via show vrf, including CLI error-banner guarding and continuation-row parsing.
device-discovery/custom_napalm/CLAUDE.md	Documents get_network_instances() output shape, conventions, and validation checklist updates.
device-discovery/tests/custom_drivers/huawei_vrp/mock_data/test_get_network_instances/normal/expected_result.json	Adds VRP normal-case expected get_network_instances() payload.
device-discovery/tests/custom_drivers/huawei_vrp/mock_data/test_get_network_instances/normal/display_ip_vpn-instance.txt	Adds VRP summary command fixture (normal scenario).
device-discovery/tests/custom_drivers/huawei_vrp/mock_data/test_get_network_instances/normal/display_ip_vpn-instance_interface.txt	Adds VRP interface-membership command fixture (normal scenario).
device-discovery/tests/custom_drivers/huawei_vrp/mock_data/test_get_network_instances/no_instances/expected_result.json	Adds VRP empty/no-instances expected payload.
device-discovery/tests/custom_drivers/huawei_vrp/mock_data/test_get_network_instances/af_column_variant/expected_result.json	Adds VRP AF-column variant expected payload.
device-discovery/tests/custom_drivers/huawei_vrp/mock_data/test_get_network_instances/af_column_variant/display_ip_vpn-instance.txt	Adds VRP AF-column variant summary fixture.
device-discovery/tests/custom_drivers/huawei_vrp/mock_data/test_get_network_instances/af_column_variant/display_ip_vpn-instance_interface.txt	Adds VRP AF-column variant interface-membership fixture.
device-discovery/tests/custom_drivers/hp_comware/mock_data/test_get_network_instances/normal/expected_result.json	Adds Comware normal-case expected payload.
device-discovery/tests/custom_drivers/hp_comware/mock_data/test_get_network_instances/normal/display_ip_vpn-instance.txt	Adds Comware summary fixture (normal scenario).
device-discovery/tests/custom_drivers/hp_comware/mock_data/test_get_network_instances/normal/display_ip_vpn-instance_instance-name_cust-a.txt	Adds Comware per-instance detail fixture (cust-a).
device-discovery/tests/custom_drivers/hp_comware/mock_data/test_get_network_instances/normal/display_ip_vpn-instance_instance-name_mgmt-vpn.txt	Adds Comware per-instance detail fixture (mgmt-vpn).
device-discovery/tests/custom_drivers/hp_comware/mock_data/test_get_network_instances/no_instances/expected_result.json	Adds Comware empty/no-instances expected payload.
device-discovery/tests/custom_drivers/hp_comware/mock_data/test_get_network_instances/multi_member_wrap/expected_result.json	Adds Comware wrapped multi-member list expected payload.
device-discovery/tests/custom_drivers/hp_comware/mock_data/test_get_network_instances/multi_member_wrap/display_ip_vpn-instance.txt	Adds Comware summary fixture (wrap scenario).
device-discovery/tests/custom_drivers/hp_comware/mock_data/test_get_network_instances/multi_member_wrap/display_ip_vpn-instance_instance-name_wrap-vpn.txt	Adds Comware per-instance wrapped interface-list detail fixture.
device-discovery/tests/custom_drivers/cumulus_linux/mock_data/test_get_network_instances/normal/expected_result.json	Adds Cumulus normal-case expected payload.
device-discovery/tests/custom_drivers/cumulus_linux/mock_data/test_get_network_instances/normal/ip_vrf_show.txt	Adds ip vrf show fixture.
device-discovery/tests/custom_drivers/cumulus_linux/mock_data/test_get_network_instances/normal/ip_link_show_master_red.txt	Adds ip link show master red fixture.
device-discovery/tests/custom_drivers/cumulus_linux/mock_data/test_get_network_instances/normal/ip_link_show_master_mgmt.txt	Adds ip link show master mgmt fixture.
device-discovery/tests/custom_drivers/cumulus_linux/mock_data/test_get_network_instances/no_vrfs/expected_result.json	Adds Cumulus empty/no-VRFs expected payload.
device-discovery/tests/custom_drivers/dell_sonic/mock_data/test_get_network_instances/normal/expected_result.json	Adds SONiC normal-case expected payload.
device-discovery/tests/custom_drivers/dell_sonic/mock_data/test_get_network_instances/normal/show_vrf.txt	Adds SONiC show vrf fixture (normal scenario).
device-discovery/tests/custom_drivers/dell_sonic/mock_data/test_get_network_instances/no_vrfs/expected_result.json	Adds SONiC empty/no-VRFs expected payload.
device-discovery/tests/custom_drivers/dell_sonic/mock_data/test_get_network_instances/unsupported_command/expected_result.json	Adds SONiC unsupported-command expected payload (guard behavior).
device-discovery/tests/custom_drivers/dell_sonic/mock_data/test_get_network_instances/unsupported_command/show_vrf.txt	Adds SONiC unsupported show vrf error-banner fixture.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.