[NAE-2418] Verify @Transient handling across persistence layers in na…#436
Open
renczesstefan wants to merge 2 commits intorelease/7.0.0-rev10from
Open
[NAE-2418] Verify @Transient handling across persistence layers in na…#436renczesstefan wants to merge 2 commits intorelease/7.0.0-rev10from
renczesstefan wants to merge 2 commits intorelease/7.0.0-rev10from
Conversation
…e-spring-core-adapter Replaced the incorrect `java.beans.Transient` import with `org.springframework.data.annotation.Transient`. This ensures proper handling of transiency in the context of Spring Data.
WalkthroughCore Petri net arc classes were made abstract; new Spring adapter arc subclasses (Arc, InhibitorArc, ReadArc, ResetArc) were added with Spring Data Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Retoocs
previously approved these changes
Apr 27, 2026
…e-spring-core-adapter - created new arc classes in spring core adapter - refactored existing arc class to be abstract - added transient to arcs
renczesstefan
dismissed stale reviews from Retoocs and coderabbitai[bot]
via
3f362f9
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetEventHandler.java`:
- Around line 21-24: Remove the no-op Spring Data lifecycle hook by deleting the
onAfterLoad(AfterLoadEvent<PetriNet> event) method from the PetriNetEventHandler
class and also remove the unused AfterLoadEvent import; ensure no other code
references onAfterLoad so compilation remains clean.
In
`@nae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/petrinet/domain/arcs/Arc.java`:
- Around line 12-14: The copy constructor public Arc(Arc arc) is too narrowly
typed; change its parameter to the core/base arc type (the base Arc
interface/class used by the superclass) so it can accept core arcs, e.g. public
Arc(BaseArcType arc) { super(arc); }, and update the import for that core/base
Arc type; keep the body calling super(arc) unchanged to delegate copying to the
superclass.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d5fe2af9-b04f-42a0-b2dd-3da8dca5d1d3
📒 Files selected for processing (10)
application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/ArcFactory.javaapplication-engine/src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetEventHandler.javanae-object-library/src/main/java/com/netgrif/application/engine/objects/petrinet/domain/arcs/Arc.javanae-object-library/src/main/java/com/netgrif/application/engine/objects/petrinet/domain/arcs/InhibitorArc.javanae-object-library/src/main/java/com/netgrif/application/engine/objects/petrinet/domain/arcs/ReadArc.javanae-object-library/src/main/java/com/netgrif/application/engine/objects/petrinet/domain/arcs/ResetArc.javanae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/petrinet/domain/arcs/Arc.javanae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/petrinet/domain/arcs/InhibitorArc.javanae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/petrinet/domain/arcs/ReadArc.javanae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/petrinet/domain/arcs/ResetArc.java
Comment on lines
+21
to
+24
| @Override | ||
| public void onAfterLoad(AfterLoadEvent<PetriNet> event) { | ||
|
|
||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether this callback is intentionally used/covered elsewhere.
rg -n -C3 --type=java '\bonAfterLoad\s*\(\s*AfterLoadEvent<PetriNet>\s+event\s*\)'
rg -n -C3 --type=java '\bPetriNetEventHandler\b'
rg -n -C3 --type=java --iglob '*test*' 'AfterLoadEvent|PetriNetEventHandler|onAfterLoad\s*\('Repository: netgrif/application-engine
Length of output: 1901
Remove the empty onAfterLoad callback.
The onAfterLoad method at lines 21–24 is a no-op Spring Data lifecycle hook that is never invoked or tested. Remove the method and its unused AfterLoadEvent import (line 11).
Cleanup diff
-import org.springframework.data.mongodb.core.mapping.event.AfterLoadEvent;
@@
- `@Override`
- public void onAfterLoad(AfterLoadEvent<PetriNet> event) {
-
- }
-🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetEventHandler.java`
around lines 21 - 24, Remove the no-op Spring Data lifecycle hook by deleting
the onAfterLoad(AfterLoadEvent<PetriNet> event) method from the
PetriNetEventHandler class and also remove the unused AfterLoadEvent import;
ensure no other code references onAfterLoad so compilation remains clean.
Comment on lines
+12
to
+14
| public Arc(Arc arc) { | ||
| super(arc); | ||
| } |
There was a problem hiding this comment.
Copy constructor is too narrowly typed.
At Line 12, Arc(Arc arc) only accepts the adapter type, which prevents copying when the source is referenced as the core/base arc type. Use the core arc type in the constructor signature.
Proposed fix
- public Arc(Arc arc) {
+ public Arc(com.netgrif.application.engine.objects.petrinet.domain.arcs.Arc arc) {
super(arc);
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@nae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/petrinet/domain/arcs/Arc.java`
around lines 12 - 14, The copy constructor public Arc(Arc arc) is too narrowly
typed; change its parameter to the core/base arc type (the base Arc
interface/class used by the superclass) so it can accept core arcs, e.g. public
Arc(BaseArcType arc) { super(arc); }, and update the import for that core/base
Arc type; keep the body calling super(arc) unchanged to delegate copying to the
superclass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements NAE-2418
Dependencies
No new dependencies were introduced.
Third party dependencies
There are no dependencies on other PR.
Blocking Pull requests
There are no dependencies on other PR.
How Has Been This Tested?
This was tested manually and with unit tests.
Test Configuration
Checklist:
Summary by CodeRabbit