Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-Provider Transcription Support (REST/Batch Path) #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Multi-Provider Transcription Support (REST/Batch Path) #31
Changes from 11 commits
663ee63c99950dc00f3a4bd702d6edd5bc2b4cae58ed7b4d89ae7a1a3558f240209e321b43d0d0d7edfd80be3b2c45a0f0bb8a90d2fe7c1819ff74984e07e26d2872696b07a641a1d54a74333c5716fa2034d83c7b1f896a7a85e0513f84dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Container builds install only
requirements.txt, but the new transcription providers (andapi.py) import/usehttpxdirectly.httpxis currently only listed inrequirements-dev.txt, so the runtime image may rely on a transitive dependency (or fail if that transitive dep changes). Addhttpxtorequirements.txtto make the container/runtime dependency explicit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs say
channel0_name/channel1_namerenames diarization labels by replacingChannel 0/1:orSpeaker 0/1:. VoxTral currently formats diarization labels asspeaker_1:/speaker_2:(lowercase + underscore), so these overrides won’t apply for VoxTral unless labels are normalized or the replacement logic is expanded. Please clarify provider-specific behavior here (and/or adjust the code) so users aren’t misled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
providerrequest parameter introduces new behavior (per-request provider override), but there’s no API-level test exercising theprovider=voxtralpath. Adding a test that setsprovider=voxtraland mockstranscription.voxtral.httpx.AsyncClientwould validate provider selection + response handling end-to-end for the endpoint.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generic exception handler returns the raw exception message to the client (
detail=f"An error occurred: {str(e)}"), which can leak internal details. Prefer a generic client-facing message (and keep the full exception only in logs), similar to the earlier behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Channel/speaker renaming won’t catch Deepgram’s uppercase labels (e.g., "SPEAKER 0:" / "SPEAKER 1:"), so
channel0_name/channel1_namewon’t apply for the transcript format used in tests and likely production. Consider handling both "Speaker" and "SPEAKER" (or doing a case-insensitive replace / regex anchored on the label).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been addressed in commit
41a1d54(fixup forrefactor(api): use transcription provider abstraction), which addsCHANNEL 0/1:andSPEAKER 0/1:uppercase variants alongside the existing mixed-case replacements. Note: this item is a duplicate of #31 (comment) — both have been resolved by the same change.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.