Twiggy compiler fixes#2
Open
jcheron wants to merge 6 commits into
Open
Conversation
remove raw optimization
{{array['key']}} => {$array['key']}
{{object->attribute}} => {$object->attribute}
add function_exists test for twig functions
{{ _self }} => {$this->getName()}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed:
raw filter
Twig
rawfilter is not interpreted.{{foo|raw}}{$foo|noescape}{$foo}see 7aaba40
Twig array access
Access to the element of a Twig array is transformed into access to the member of an object.
{{bar['foo']}}{$bar['foo']}{$bar->foo}see 209d1fb
Twig and Twiggy coexisting
pb with Twig already installed in a project (cannot redeclare Twig global functions...)
function_existsthe previous declaration of the Twig global functions, see c1a06ed_self replacement with toString
Replacing
{{_self}}with{$_self}is problematic:_selfwith Twig refers to the template instance, using it alone in an expression calls the toString which displays the template name.$_selfis not defined with Latte{{_self}}{$this->getName()}{$_self}see 5250d9c
Unit tests
The unit tests have been modified accordingly: see 4a2e2f5