Conversation
A mutation dispatched from a chooser option records the transition the option owes; the retry of that intent finishes it instead of re-serving the answered chooser (s-tac-do6). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…intent replaceSummary, wipStart, wipDone and wipRemove allocate their identity and precondition before the intent, publish once under the intent's key through the store's document publication, and report their effects. A summary replacement conditions on the document it replaces. The prepared-write path it replaces goes: ApplyPrepared, revalidation, the recovery projections and notices, the recover command, and the store's apply and reconcile ports. Delivers the summary and WIP requirements of 20260914-113911-d-tac-wgw. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Comment on lines
+131
to
+132
| if s.publicationGit == nil || !isGitRevision(required) { | ||
| return false, nil |
There was a problem hiding this comment.
Causal revision history is lost
When IncludesRevision names a successful write and the branch has advanced, a newly constructed read store has no in-memory lineage and no PublicationGit. This path therefore returns false even though the current snapshot contains the requested revision. Repository target reads create exactly this kind of fresh store, so a valid causal search can fail with “current revision cannot be shown to include the requested write” after an intervening publication. Please preserve durable lineage or make Git ancestry available to read stores.
Prompt To Fix With AI
This is a comment left during a code review.
Path: pkg/local/read_snapshot.go
Line: 131-132
Comment:
**Causal revision history is lost**
When `IncludesRevision` names a successful write and the branch has advanced, a newly constructed read store has no in-memory lineage and no `PublicationGit`. This path therefore returns false even though the current snapshot contains the requested revision. Repository target reads create exactly this kind of fresh store, so a valid causal search can fail with “current revision cannot be shown to include the requested write” after an intervening publication. Please preserve durable lineage or make Git ancestry available to read stores.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone 4 slice 4, upstream half. Summary correction and the WIP marker writes move onto the recorded-intent publication path that capture uses, and the prepared-write path they were the last users of is removed.
replaceSummary,wipStart,wipDoneandwipRemoveallocate identities and the precondition before the intent, publish once under the intent's key, and report their effects. A retry finds its own publication and never overwrites a later one; a summary replacement conditions on the document it replaces and answers a moved document with a conflict carrying the current summary; removing an absent marker succeeds.PublicationStorereplacesEntryPublicationStoreand addsReadDocument,LookupDocumentPublicationandPublishDocument;GraphStorelosesApplyandReconcile. The conformance suite covers keyed publication, replacement preconditions and absent removals.ApplyPrepared/PreparedTransition, revalidation, the recovery projections and notices,sdd recover, the local store's transaction and apply-record machinery, and therecoveryinject argument.Delivers the summary and WIP requirements of 20260914-113911-d-tac-wgw; the hosted half follows in sdd-product.
🤖 Generated with Claude Code
The PR is not safe to merge until repository reads can prove that a newer branch revision contains a requested successful write.
Findings
Fix with agent prompt
Summary
This PR moves summary replacements and WIP marker changes onto intent-keyed publication, records chooser transitions for retries, and removes the prepared-transition recovery machinery.
Reviews (1) · Last reviewed commit: "feat(application): publish summary and W..."