-
Notifications
You must be signed in to change notification settings - Fork 415
feat: Add GCP Managed Kafka metrics to existing KAFKACLUSTER and KAFKATOPIC entities (NR-565785) #2981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sparsi17
wants to merge
4
commits into
newrelic:main
Choose a base branch
from
sparsi17:feat/gcp-kafka-existing-entities
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add GCP Managed Kafka metrics to existing KAFKACLUSTER and KAFKATOPIC entities (NR-565785) #2981
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2e1ebd0
feat: Add GCP Managed Kafka support to KAFKACLUSTER and KAFKATOPIC en…
sparsi17 51e027f
fix: Add gcp: blocks to existing golden metrics instead of standalone…
sparsi17 57ab063
feat: Add gcp: block to partitionCount + update summary_metrics for K…
sparsi17 750fc5a
fix: Match aggregation functions in gcp: blocks with other query bloc…
sparsi17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| { | ||
| "name": "GCP Managed Kafka Cluster", | ||
| "description": null, | ||
| "pages": [ | ||
| { | ||
| "name": "GCP Managed Kafka Cluster", | ||
| "description": null, | ||
| "widgets": [ | ||
| { | ||
| "title": "CPU Core Usage (vCPU/s)", | ||
| "layout": { | ||
| "column": 1, | ||
| "row": 1, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT rate(sum(`gcp.managedkafka.cpu.core_usage_time`), 1 minute) AS 'CPU (vCPU/s)' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "title": "Offline Partitions", | ||
| "layout": { | ||
| "column": 5, | ||
| "row": 1, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT average(`gcp.managedkafka.offline_partitions`) AS 'Offline Partitions' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "title": "Request Latency p99 (ms)", | ||
| "layout": { | ||
| "column": 9, | ||
| "row": 1, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT average(`gcp.managedkafka.request_latencies`) AS 'p99 (ms)' WHERE `entity.guid` = '{{entity.guid}}' AND `metric.percentile` = '99' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "title": "Messages In", | ||
| "layout": { | ||
| "column": 1, | ||
| "row": 4, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT sum(`gcp.managedkafka.cluster_message_in_count`) AS 'Messages In' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "title": "Bytes In/Out", | ||
| "layout": { | ||
| "column": 5, | ||
| "row": 4, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT sum(`gcp.managedkafka.cluster_byte_in_count`) AS 'Bytes In', sum(`gcp.managedkafka.cluster_byte_out_count`) AS 'Bytes Out' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "title": "Memory Usage", | ||
| "layout": { | ||
| "column": 9, | ||
| "row": 4, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT average(`gcp.managedkafka.memory.usage`) AS 'Memory (bytes)' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,41 @@ | ||
| providerAccountName: | ||
| tag: | ||
| key: providerAccountName | ||
| title: GCP account | ||
| unit: STRING | ||
|
|
||
| gcpProjectId: | ||
| tag: | ||
| key: gcp.projectId | ||
| title: GCP Project ID | ||
| unit: STRING | ||
|
|
||
| brokers: | ||
| goldenMetric: brokerCount | ||
| unit: COUNT | ||
| title: Brokers | ||
|
|
||
| topicCount: | ||
| title: Topics | ||
| unit: COUNT | ||
| goldenMetric: TopicCount | ||
| unit: COUNT | ||
| title: Topics | ||
|
|
||
| partitionCount: | ||
| goldenMetric: partitionCount | ||
| unit: COUNT | ||
| title: Partitions count | ||
| title: Partitions | ||
|
|
||
| offlinePartitions: | ||
| goldenMetric: offlinePartitions | ||
| unit: COUNT | ||
| title: Offline partitions | ||
| title: Offline Partitions | ||
|
|
||
| gcpCpuUsage: | ||
| goldenMetric: gcpCpuUsage | ||
| unit: COUNT | ||
| title: CPU Usage (vCPU/s) | ||
|
|
||
| gcpRequestLatency: | ||
| goldenMetric: gcpRequestLatency | ||
| unit: MS | ||
| title: Request Latency p99 (ms) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| { | ||
| "name": "GCP Managed Kafka Topic", | ||
| "description": null, | ||
| "pages": [ | ||
| { | ||
| "name": "GCP Managed Kafka Topic", | ||
| "description": null, | ||
| "widgets": [ | ||
| { | ||
| "title": "Messages In", | ||
| "layout": { | ||
| "column": 1, | ||
| "row": 1, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT sum(`gcp.managedkafka.message_in_count`) AS 'Messages In' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't need to keep entity.guid filter in entity platform dashboard files. |
||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "title": "Bytes In", | ||
| "layout": { | ||
| "column": 5, | ||
| "row": 1, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT sum(`gcp.managedkafka.byte_in_count`) AS 'Bytes In' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "title": "Bytes Out", | ||
| "layout": { | ||
| "column": 9, | ||
| "row": 1, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT sum(`gcp.managedkafka.byte_out_count`) AS 'Bytes Out' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "title": "Topic Errors", | ||
| "layout": { | ||
| "column": 1, | ||
| "row": 4, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT sum(`gcp.managedkafka.topic_error_count`) AS 'Errors' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "title": "Request Count", | ||
| "layout": { | ||
| "column": 5, | ||
| "row": 4, | ||
| "width": 4, | ||
| "height": 3 | ||
| }, | ||
| "visualization": { | ||
| "id": "viz.line" | ||
| }, | ||
| "rawConfiguration": { | ||
| "nrqlQueries": [ | ||
| { | ||
| "accountId": 0, | ||
| "query": "FROM Metric SELECT sum(`gcp.managedkafka.topic_request_count`) AS 'Requests' WHERE `entity.guid` = '{{entity.guid}}' TIMESERIES AUTO" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this dashboard.json is referenced? generally dashboard.json should reference in definition.yml. And always we should first make changes in stg.yml files and get them merged and test properly on staging. .yml files are for production. If stg files doesn't exist then .yml will be for all.