feat(qoe): add 7 new aggregate KPIs#216
Open
skatti97 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 7 new KPIs to the
QOE_AGGREGATEevent and bumpsqoeAggregateVersionto1.1.0for cross-platform parity with video-agent-android.avgDownloadRateminDownloadRatemaxDownloadRatetotalSwitchUpstotalSwitchDownstotalPauseTimetotalRenditionsHow it's wired
All 7 KPIs live entirely on
NRQoEAggregator— no new tracker-side state. The aggregator observes the assembled attribute dict that already flows throughprocessAction:, mirroring the existing pattern for totalRebufferingTime.Three design choices worth knowing:
avgDownloadRate skips consecutive duplicate samples. AVPlayer's
accessLog.events.lastObjectreturns the same entry between real network events, so naïve every-event observation would bias the mean toward whichever rate was sticky during the longest idle window. The aggregator only accumulates on change — true mean over distinct download events.totalPauseTime consumes
timeSincePausedfrom the existing timeSince table instead of running its own clock. Mid-pause harvest still reports correctly via an open-segment snapshot in generateAggregateAttributes — written to a local var, never back intoself.totalPauseTime, so the matching RESUME doesn't double-count.totalRenditions keys on width × height, not bitrate. Pixel-area keying is robust to streams that label distinct resolution variants with the same bitrate. Initial rendition is seeded at CONTENT_START because
NRTrackerAVPlayer.checkRenditionChange(lines 351-354) silently stamps the first observation without firing CONTENT_RENDITION_CHANGE.Auto-wired:
Test plan