Skip to content

Fix accessibility of app navigation toggle #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jancborchardt wants to merge 3 commits into from
Closed

Fix accessibility of app navigation toggle #1843

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34801e5
Increase visibility of app navigation toggle hover/focus state
jancborchardt Apr 13, 2021
6ef930b
Add aria-label to AppNavigationToggle
jancborchardt Apr 13, 2021
72dfd5b
Fix warnings and undefined function
raimund-schluessler Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/components/AppNavigationToggle/AppNavigationToggle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,34 @@
<a class="app-navigation-toggle"
href="#"
:aria-expanded="open ? 'true' : 'false'"
:aria-label="ariaLabel"
aria-controls="app-navigation-vue"
@click.prevent="toggleNavigation"
@keydown.space.exact.prevent="toggleNavigation" />
</template>

<script>
import l10n from '../../mixins/l10n'

export default {

name: 'AppNavigationToggle',
Comment thread
jancborchardt marked this conversation as resolved.

mixins: [l10n],

props: {
open: {
type: Boolean,
required: true,
},
},

computed: {
ariaLabel() {
return this.open ? this.t('Close navigation') : this.t('Open navigation')
},
},

methods: {
toggleNavigation() {
this.$emit('update:open', !this.open)
Expand Down Expand Up @@ -72,6 +83,8 @@ export default {
&:hover,
&:focus {
opacity: $opacity_full;
background-color: var(--color-background-hover);
border-radius: var(--border-radius-pill);
Comment thread
raimund-schluessler marked this conversation as resolved.
}
}

Expand Down