feat(NcSelect): add helperText support#8787
Open
skjnldsv wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8787 +/- ##
==========================================
+ Coverage 53.31% 53.37% +0.06%
==========================================
Files 109 109
Lines 3697 3702 +5
Branches 1083 1085 +2
==========================================
+ Hits 1971 1976 +5
Misses 1472 1472
Partials 254 254 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add a helperText prop rendered beneath the control (via vue-select's footer slot, for both single and multi mode), matching NcInputField's helper text styling, and linked to the input through aria-describedby. Anchor the absolute actions/caret to the dropdown-toggle so the helper text below it does not shift the caret's vertical centering. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/ncselect-helper-text
branch
from
July 24, 2026 13:06
b73bd9f to
035bd08
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
marked this pull request as draft
July 24, 2026 18:50
skjnldsv
marked this pull request as ready for review
July 24, 2026 18:51
skjnldsv
added
3. to review
ShGKme
reviewed
Jul 24, 2026
ShGKme
left a comment
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
No way to use NcInput's existing helper text?
It also supports the error state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the NcInput