Skip to content

feat(auto-upload): battery saver, batter optimization indication#16934

Merged
alperozturk96 merged 15 commits into
masterfrom
warn-auto-upload-battery-saver-mode-distinquish-between-os-and-app
May 13, 2026
Merged

feat(auto-upload): battery saver, batter optimization indication#16934
alperozturk96 merged 15 commits into
masterfrom
warn-auto-upload-battery-saver-mode-distinquish-between-os-and-app

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Apr 28, 2026 •
edited
Loading

The difference between Android's battery saver mode and Nextcloud's app battery optimization mode was confusing. This PR clarifies that if user not has one of it.

Screenshot_20260507_134907

Changes

  • Detects battery optimization mode and battery saver mode and indicates both if needed.
  • Adds to the activity XML instead of adapter's first section
  • Fixes showing same banner for each section

@alperozturk96 alperozturk96 linked an issue Apr 28, 2026 that may be closed by this pull request
(auto:upload) battery saver detection #16843
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25058352829/artifacts/6686650006
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25060519592/artifacts/6688365587
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

alperozturk96
alperozturk96 commented Apr 29, 2026
View reviewed changes
Comment thread app/src/main/res/values/strings.xml Outdated
@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.1 milestone Apr 29, 2026
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

alperozturk96 commented Apr 29, 2026

/backport to stable-33.1.x

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25094341195/artifacts/6701043178
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 marked this pull request as draft April 30, 2026 09:50
@alperozturk96 alperozturk96 force-pushed the warn-auto-upload-battery-saver-mode-distinquish-between-os-and-app branch from ab682a4 to 7d06522 Compare May 5, 2026 09:13
@alperozturk96

This comment was marked as resolved.

Sign in to view
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25368366526/artifacts/6803481556
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the warn-auto-upload-battery-saver-mode-distinquish-between-os-and-app branch from a02f098 to 7550096 Compare May 7, 2026 11:15
@alperozturk96 alperozturk96 marked this pull request as ready for review May 7, 2026 11:49
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6767
Dodgy code216216
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total420420

tobiasKaminsky
tobiasKaminsky requested changes May 13, 2026
View reviewed changes
Comment thread app/src/main/res/values/strings.xml Outdated
Comment thread app/src/main/res/values/strings.xml Outdated
Comment thread app/src/main/res/values/strings.xml Outdated
tobiasKaminsky
tobiasKaminsky requested changes May 13, 2026
View reviewed changes
Comment thread app/src/main/res/layout/upload_warning_card.xml Outdated
@alperozturk96
feat(auto-upload): battery saver, batter optimization indication
18a686f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
feat(auto-upload): manual di
a1fd2ca 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
feat(auto-upload): fix upload list layout and fix texts
3985923 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96 and others added 11 commits May 13, 2026 11:27
@alperozturk96
feat(auto-upload): fix sync folder layout
e521f24 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
feat(auto-upload): listen live changes
f48cec7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add redirection actions
e446a8f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
688fddb 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
af34391 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
9437676 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
4fee5c5 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
a559945 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
Update app/src/main/res/values/strings.xml
eb6ca92 
Co-authored-by: Tobias Kaminsky <tobias@kaminsky.me>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@alperozturk96 @tobiasKaminsky
Update app/src/main/res/values/strings.xml
82b45b0 
Co-authored-by: Tobias Kaminsky <tobias@kaminsky.me>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@alperozturk96 @tobiasKaminsky
Update app/src/main/res/values/strings.xml
4cd3df7 
Co-authored-by: Tobias Kaminsky <tobias@kaminsky.me>
Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
@alperozturk96 alperozturk96 force-pushed the warn-auto-upload-battery-saver-mode-distinquish-between-os-and-app branch from 35f2d9c to 4cd3df7 Compare May 13, 2026 09:27
@alperozturk96
wip
183b834 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 merged commit 7c802bd into master May 13, 2026
9 of 17 checks passed
@alperozturk96 alperozturk96 deleted the warn-auto-upload-battery-saver-mode-distinquish-between-os-and-app branch May 13, 2026 09:28
@backportbot backportbot Bot mentioned this pull request May 13, 2026
Merged
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25790512331/artifacts/6966763952
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@kra-mo kra-mo Awaiting requested review from kra-mo

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review feature: auto upload

Projects

None yet

Milestone

Nextcloud App 33.1.1

Development

Successfully merging this pull request may close these issues.

(auto:upload) battery saver detection

3 participants

@alperozturk96 @AndyScherzinger @tobiasKaminsky