Open
Conversation
Contributor
|
Looks great! |
kra-mo
approved these changes
Apr 13, 2026
Member
kra-mo
left a comment
There was a problem hiding this comment.
Looks really nice :)
My only question is, does it pass WCAG AAA for high contrast? If it does, then approved.
e8f813a to
7801b3b
Compare
Contributor
Author
Contributor
Author
|
Also at @ChristophWurst's request added a little icon to see if there are multiple people invited to the event
|
7801b3b to
867479c
Compare
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
867479c to
1084f47
Compare
Contributor
|
Since we are working on event styles, can we maybe add this to the PR |
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
Contributor
Author
Sure yeah why not, but I need a plan from @kra-mo or @nimishavijay first pls. Here is how outlook currently does it:
Should we also do this? |
Member
|
Makes sense to me :) |
Member
|
This thread (for a different project) might also be of interest, quite a bit of research and experimentation there: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1433 |
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fix #8022
Fix #2353
How do we like this? It passes WCAG AA with all colors ✅. Based on this design: #8022 (comment)
Here's what it looks like with some "normal" colors:
Here's what it looks like with the most problematic colors, still passes WCAG:
Naturally this system doesn't look great with people choosing white for their white backgrounds, but who am I to stop them from doing that (also our current system doesn't really handle that either). It passes WCAG anyway.