Skip to content

chore(network): enable again our request timeout feature #9646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgallien merged 1 commit into from
Mar 19, 2026

chore(network): enable again our request timeout feature

ee899a8
Select commit
Loading
Failed to load commit list.
Merged

chore(network): enable again our request timeout feature #9646

chore(network): enable again our request timeout feature
ee899a8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 19, 2026 in 29m 49s

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
7 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 123 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "req" of type "class QNetworkRequest" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0FpxDDWtRlZe-ICyu5&open=AZ0FpxDDWtRlZe-ICyu5&pullRequest=9646

Check warning on line 124 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "requestBody" of type "class QIODevice *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0FpxDDWtRlZe-ICyu6&open=AZ0FpxDDWtRlZe-ICyu6&pullRequest=9646

Check warning on line 387 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0FpxDDWtRlZe-ICyu4&open=AZ0FpxDDWtRlZe-ICyu4&pullRequest=9646

Check warning on line 137 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "req" of type "class QNetworkRequest" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0FpxDDWtRlZe-ICyu7&open=AZ0FpxDDWtRlZe-ICyu7&pullRequest=9646

Check failure on line 279 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0FpxDDWtRlZe-ICyu8&open=AZ0FpxDDWtRlZe-ICyu8&pullRequest=9646

Check warning on line 591 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "reply" of type "class QNetworkReply *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0FpxDDWtRlZe-ICyu-&open=AZ0FpxDDWtRlZe-ICyu-&pullRequest=9646

Check warning on line 591 in src/libsync/abstractnetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "reply" is "class QNetworkReply *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0FpxDDWtRlZe-ICyu9&open=AZ0FpxDDWtRlZe-ICyu9&pullRequest=9646
View more details on SonarQubeCloud