Skip to content

fix(gui/settings): use different palette colour for backgrounds #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilsding merged 2 commits into from
Mar 26, 2026
+34 −9

fix(gui/settings): keep using AlternateBase as background on Windows

75c8ace
Select commit
Loading
Failed to load commit list.
Merged

fix(gui/settings): use different palette colour for backgrounds #9703

fix(gui/settings): keep using AlternateBase as background on Windows
75c8ace
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 26, 2026 in 23m 39s

Quality Gate failed

Failed conditions
59 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 85 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "widget" of type "const class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPij&open=AZ0piJWi7ASJbBRNzPij&pullRequest=9703

Check warning on line 1829 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find_if" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjM&open=AZ0piJd-7ASJbBRNzPjM&pullRequest=9703

Check warning on line 1892 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "layout" of type "class QHBoxLayout *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjO&open=AZ0piJd-7ASJbBRNzPjO&pullRequest=9703

Check warning on line 54 in src/gui/networksettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "->" with "::" for access to "Theme::doNotUseProxy". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJe37ASJbBRNzPjU&open=AZ0piJe37ASJbBRNzPjU&pullRequest=9703

Check warning on line 1223 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjI&open=AZ0piJd-7ASJbBRNzPjI&pullRequest=9703

Check warning on line 1640 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjL&open=AZ0piJd-7ASJbBRNzPjL&pullRequest=9703

Check failure on line 50 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPib&open=AZ0piJWi7ASJbBRNzPib&pullRequest=9703

Check failure on line 230 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "=default" instead of the default implementation of this special member functions. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPip&open=AZ0piJWi7ASJbBRNzPip&pullRequest=9703

Check warning on line 240 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this method "resizeEvent" to simply inherit it. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPiq&open=AZ0piJWi7ASJbBRNzPiq&pullRequest=9703

Check warning on line 1866 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "actionSetupE2e" is "class QAction *const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjN&open=AZ0piJd-7ASJbBRNzPjN&pullRequest=9703

Check failure on line 68 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPi7&open=AZ0piJd-7ASJbBRNzPi7&pullRequest=9703

Check warning on line 549 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "navigationScroll" of type "class QScrollArea *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPi2&open=AZ0piJWi7ASJbBRNzPi2&pullRequest=9703

Check warning on line 185 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "accountSpacer" of type "class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPin&open=AZ0piJWi7ASJbBRNzPin&pullRequest=9703

Check warning on line 361 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "account" is "class OCC::Account *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPit&open=AZ0piJWi7ASJbBRNzPit&pullRequest=9703

Check warning on line 447 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPid&open=AZ0piJWi7ASJbBRNzPid&pullRequest=9703

Check failure on line 239 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjA&open=AZ0piJd-7ASJbBRNzPjA&pullRequest=9703

Check warning on line 500 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "job" of type "class OCC::EncryptFolderJob *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjF&open=AZ0piJd-7ASJbBRNzPjF&pullRequest=9703

Check failure on line 562 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPi6&open=AZ0piJWi7ASJbBRNzPi6&pullRequest=9703

Check failure on line 240 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjB&open=AZ0piJd-7ASJbBRNzPjB&pullRequest=9703

Check warning on line 100 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace constant with "std::numbers::phi_v<float>". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPik&open=AZ0piJWi7ASJbBRNzPik&pullRequest=9703

Check warning on line 757 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjH&open=AZ0piJd-7ASJbBRNzPjH&pullRequest=9703

Check warning on line 134 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "event" of type "class QMouseEvent *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPil&open=AZ0piJWi7ASJbBRNzPil&pullRequest=9703

Check warning on line 240 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "event" of type "class QResizeEvent *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPir&open=AZ0piJWi7ASJbBRNzPir&pullRequest=9703

Check warning on line 137 in src/gui/settingsdialog.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "window" of type "const class QWidget *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJWi7ASJbBRNzPim&open=AZ0piJWi7ASJbBRNzPim&pullRequest=9703

Check failure on line 1906 in src/gui/accountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ0piJd-7ASJbBRNzPjR&open=AZ0piJd-7ASJbBRNzPjR&pullRequest=9703
View more details on SonarQubeCloud