Skip to content

fix(upload): skip locked files during upload to avoid errors#9810

Open
mgallien wants to merge 5 commits intomasterfrom
bugfix/uploadLockedFiles
Open

fix(upload): skip locked files during upload to avoid errors#9810
mgallien wants to merge 5 commits intomasterfrom
bugfix/uploadLockedFiles

Conversation

@mgallien
Copy link
Copy Markdown
Collaborator

@mgallien mgallien commented Apr 8, 2026

No description provided.

@mgallien mgallien added this to the 34.0.0 milestone Apr 8, 2026
@mgallien
Copy link
Copy Markdown
Collaborator Author

mgallien commented Apr 8, 2026

/backport to stable-33.0

Comment thread src/libsync/propagateuploadv1.cpp Outdated
@mgallien mgallien force-pushed the bugfix/uploadLockedFiles branch 2 times, most recently from 1e244ba to 0325789 Compare April 8, 2026 16:44
@mgallien mgallien force-pushed the bugfix/uploadLockedFiles branch 7 times, most recently from 8c3e1f0 to 6436f6e Compare April 18, 2026 07:54
@mgallien mgallien requested a review from nilsding April 18, 2026 08:02
@mgallien mgallien force-pushed the bugfix/uploadLockedFiles branch from 6436f6e to 9d99f89 Compare April 18, 2026 08:02
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
will ensure we watch them and sync them as soon as they are no longer
locked

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
fix behavior to match expectations from existing automated tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/uploadLockedFiles branch from 9d99f89 to c4b636a Compare April 20, 2026 09:58
@github-actions
Copy link
Copy Markdown

Artifact containing the AppImage: nextcloud-appimage-pr-9810.zip

Digest: sha256:c2b621641415fd6283d9f2c1da65bc20b4195673555031a49e4c7f7146139ec6

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
34.8% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)
145 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants