Skip to content

fix(propagateupload): ensure file size stays the same for new uploads #9823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nilsding wants to merge 2 commits into
base: master
Choose a base branch
from
+120 −1

fix(propagateupload): ensure file size stays the same for new uploads

987dbfe
Select commit
Loading
Failed to load commit list.
Open

fix(propagateupload): ensure file size stays the same for new uploads #9823

fix(propagateupload): ensure file size stays the same for new uploads
987dbfe
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 10, 2026 in 17m 37s

Quality Gate failed

Failed conditions
10 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 445 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "fileSizesChangedForNewItem" of type "_Bool" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY4F&open=AZ138BHF8C5q95abOY4F&pullRequest=9823

Check warning on line 74 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "bytesSent" of type "long long" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY4B&open=AZ138BHF8C5q95abOY4B&pullRequest=9823

Check warning on line 162 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY4E&open=AZ138BHF8C5q95abOY4E&pullRequest=9823

Check warning on line 760 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion from 'qint64' (aka 'long long') to 'double' may lose precision 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY39&open=AZ138BHF8C5q95abOY39&pullRequest=9823

Check warning on line 768 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::remove" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY4G&open=AZ138BHF8C5q95abOY4G&pullRequest=9823

Check warning on line 187 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "_aborting". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY3-&open=AZ138BHF8C5q95abOY3-&pullRequest=9823

Check warning on line 74 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "bytesTotal" of type "long long" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY4C&open=AZ138BHF8C5q95abOY4C&pullRequest=9823

Check warning on line 186 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "_deleteExisting". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY4A&open=AZ138BHF8C5q95abOY4A&pullRequest=9823

Check warning on line 185 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "_finished". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY3_&open=AZ138BHF8C5q95abOY3_&pullRequest=9823

Check warning on line 117 in src/libsync/propagateupload.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ138BHF8C5q95abOY4D&open=AZ138BHF8C5q95abOY4D&pullRequest=9823
View more details on SonarQubeCloud