Skip to content

fix: improve socket validation#9860

Open
Rello wants to merge 5 commits intomasterfrom
Rello-patch-1
Open

fix: improve socket validation#9860
Rello wants to merge 5 commits intomasterfrom
Rello-patch-1

Conversation

@Rello
Copy link
Copy Markdown
Collaborator

@Rello Rello commented Apr 17, 2026

fix: improve socket validation

Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
@Rello Rello marked this pull request as draft April 17, 2026 10:39
@Rello Rello added this to the 33.0.3 milestone Apr 17, 2026
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)
29 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

mgallien and others added 3 commits April 17, 2026 14:24
there is no way to undo leaving a share. Better ask users for
confirmation

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
@Rello Rello marked this pull request as ready for review April 20, 2026 12:53
@github-actions
Copy link
Copy Markdown

Artifact containing the AppImage: nextcloud-appimage-pr-9860.zip

Digest: sha256:4e66666edf87fc056a52ec9d6ac7501812b73816852d17b25c7972d6430dc0b5

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants