fix: allow map popup to reopen after being closed - #1634
Merged
CarlSchwan merged 1 commit intoJul 30, 2026
Merged
Conversation
Clicking on the map only opened the popup on the very first click. Subsequent clicks were silently ignored. The onMapNormalLeftClick handler used Leaflet's internal map._popup property to detect whether a popup was currently open. After the ClickSearchPopup marker was removed from the map, this reference could persist as stale and non-null, causing every following click to believe a popup was still active. The leftClickSearching flag already tracks whether our popup is open, making the map._popup check redundant. Removing it restores the expected open/close toggle behavior. Signed-off-by: Sim贸 Albert i Beltran <sim6@probeta.net>
Contributor
Author
|
@CarlSchwan Could you review it? |
CarlSchwan
approved these changes
Jul 30, 2026
CarlSchwan
enabled auto-merge
July 30, 2026 14:23
Contributor
Author
|
:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking on the map only opened the popup on the very first click. Subsequent clicks were silently ignored.
The onMapNormalLeftClick handler used Leaflet's internal map._popup property to detect whether a popup was currently open. After the ClickSearchPopup marker was removed from the map, this reference could persist as stale and non-null, causing every following click to believe a popup was still active.
The leftClickSearching flag already tracks whether our popup is open, making the map._popup check redundant. Removing it restores the expected open/close toggle behavior.