Adding CONTRIBUTING.md#1509
Open
phyy-nx wants to merge 3 commits into
Open
Conversation
Contributor
|
LGTM although I would suggest capitalizing all the words in "NeXus international advisory committee." |
Contributor
Author
|
👍 |
Contributor
|
In the third paragraph, please change this text from: to: |
Contributor
Author
|
Done. I purport this is merely echoing the constitution and established practices and therefore doesn't need a vote, but disagreement is welcome. |
Contributor
|
In today's Telco, it was discussed that the preferred way of merging PR is doing a squash commit. This prevents the situation in #1424, where a couple hundreds a small commits were added to the history of the main branch. This had to be resolved in #1566 manually. I think it would be a good idea to state this here explicitly (and also make squash commits the default in the settings, as @PeterC-DLS wanted to set it up). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft of a CONTRIBUTING guide, based on conversation from the recent Telco. This guide tries to layout the existing NeXus contribution guidelines, including issue and pull request guides.
Feedback welcome.