Skip to content

swapped chromap index decompression from nf-core module untarfiles to…#532

Merged
JoseEspinosa merged 1 commit into
nf-core:devfrom
Kevin-Brockers:change_untarfiles_to_untar
Jul 21, 2026
Merged

swapped chromap index decompression from nf-core module untarfiles to…#532
JoseEspinosa merged 1 commit into
nf-core:devfrom
Kevin-Brockers:change_untarfiles_to_untar

Conversation

@Kevin-Brockers

@Kevin-Brockers Kevin-Brockers commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Closes #531

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@Kevin-Brockers Kevin-Brockers linked an issue Jul 21, 2026 that may be closed by this pull request
swap untarfiles to untarfiles to untar #531
Closed
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5f7e6a2

+| ✅ 271 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   8 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config
  • files_unchanged - File ignored due to lint config: assets/nf-core-chipseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-chipseq_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-07-21 13:39:45

JoseEspinosa
JoseEspinosa approved these changes Jul 21, 2026
View reviewed changes

@JoseEspinosa JoseEspinosa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JoseEspinosa
JoseEspinosa merged commit 127c796 into nf-core:dev Jul 21, 2026
19 checks passed
@Kevin-Brockers
Kevin-Brockers deleted the change_untarfiles_to_untar branch July 21, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

swap untarfiles to untarfiles to untar

2 participants

@Kevin-Brockers @JoseEspinosa