add log hint in modules create and add create containers to modules bump-versions#4374
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| log.info("Created following files:\n " + "\n ".join(new_files)) | ||
|
|
||
| if self.component_type == "modules": | ||
| log.info( |
There was a problem hiding this comment.
Is this the correct log level we want? Does this always show?
There was a problem hiding this comment.
yes, should always hint to use that after the creation of the module for now. later we will actually do this step here.
| """Build Seqera/Wave containers for ``components`` with a live progress display. | ||
|
|
||
| Shows an overall module bar plus, per module, the per-build spinners | ||
| (docker/singularity × platform) that :meth:`ModuleContainers.create` renders when a |
There was a problem hiding this comment.
| (docker/singularity × platform) that :meth:`ModuleContainers.create` renders when a | |
| (docker/singularity x platform) that :meth:`ModuleContainers.create` renders when a |
There was a problem hiding this comment.
\cross is the right symbol here 🤓
| raise RuntimeError(f"{error_context}: could not parse JSON response") from e | ||
|
|
||
|
|
||
| def build_containers_with_progress( |
There was a problem hiding this comment.
I am not sure if I like these static functions when they are heavily parametrized and not helping to instantiate objects, but rather expecting them as input.
They are obviously useful to simplify one specific complex flow, but here we expect a manager, components and then also the Path.
Can we redesign this a bit such that it e.g. only requires a Path and a Module name (str)?
There was a problem hiding this comment.
build_containers_with_progress lives in the same module as ModuleContainers so it is fair to assume knowledge about its instantiation. This would reduce that coupling in more distant logic that lives in command_modules etc.
| components=modules, | ||
| ) | ||
| ModuleContainers.check_tower_token() | ||
| failed_modules = build_containers_with_progress(manager, modules, self.directory) |
There was a problem hiding this comment.
We never pass force when building containers from this class. Should we resurface this?
cherry pick nf-core@6139791 and parts of nf-core@3909bcb
# Conflicts: # nf_core/modules/containers.py
153052c to
ff65f30
Compare
Merging this PR will not alter performance
|
6497a8a to
007bdde
Compare
007bdde to
40fe733
Compare
Partially taken from #4362 (everything except of running the container creation during modules creation)