Skip to content

Fix false nf-test failure on empty stderr #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sapunyangkut wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix false nf-test failure on empty stderr #4391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nf_core/components/components_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def display_nftest_output(self, nftest_out: bytes, nftest_err: bytes) -> None:
# update snapshot using nf-test --update-snapshot
self.generate_snapshot()

else:
elif nftest_err:
self.errors.append("nf-test failed")

def generate_snapshot(self) -> bool:
Expand Down
14 changes: 14 additions & 0 deletions tests/components/test_components_snapshot_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,20 @@
from ..test_components import TestComponents


@pytest.mark.parametrize(
("nftest_err", "expected_errors"),
[(b"", []), (b"error", ["nf-test failed"]), (b"Different Snapshot:", [])],
)
def test_display_nftest_output_stderr(nftest_err, expected_errors):
"""Only report an nf-test failure when stderr is non-empty."""
tester = ComponentsTest.__new__(ComponentsTest)
tester.no_prompts = False
tester.update = False
tester.errors = []
tester.display_nftest_output(b"", nftest_err)
assert tester.errors == expected_errors


class TestTestComponentsUtils(TestComponents):
def test_components_test_check_inputs(self):
"""Test the check_inputs() function - raise UserWarning because module doesn't exist"""
Expand Down