fix(nextflow_version): fail the build instead of publishing an empty payload#4318
Merged
Conversation
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…payload
The /nextflow_version endpoint is prerendered to a static file at build
time and consumed by external tooling (e.g. nf-core/setup-nextflow) that
resolves latest-* aliases from it. When the GitHub releases API was
degraded during a build, it returned no releases and the empty payload
{"latest":{},"versions":[]} got baked into the site, breaking every
downstream consumer until the next deploy (issues #3462, #4317).
Keep the endpoint prerendered (it gets heavy traffic and rarely changes),
but throw when the release list comes back empty so the build aborts and
the last successful deploy is retained rather than overwritten with a
broken one. Dropping the try/catch also lets a failed GitHub fetch
propagate and fail the build for the same reason.
Closes #4317
Closes #3462
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GoH7JeNdRpLFQhA8WMovWG
ewels
force-pushed
the
claude/nf-core-website-4317-byj9g0
branch
from
July 22, 2026 08:13
f5383eb to
012e301
Compare
mashehu
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /nextflow_version endpoint is prerendered to a static file at build
time and consumed by external tooling (e.g. nf-core/setup-nextflow) that
resolves latest-* aliases from it. When the GitHub releases API was
degraded during a build, it returned no releases and the empty payload
{"latest":{},"versions":[]} got baked into the site, breaking every
downstream consumer until the next deploy (issues #3462, #4317).
Keep the endpoint prerendered (it gets heavy traffic and rarely changes),
but throw when the release list comes back empty so the build aborts and
the last successful deploy is retained rather than overwritten with a
broken one. Dropping the try/catch also lets a failed GitHub fetch
propagate and fail the build for the same reason.
Closes #4317
Closes #3462
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01GoH7JeNdRpLFQhA8WMovWG
@netlify /nextflow_version.ts