Use actual ISM namespace prefix instead of assuming it is "ism" - #773
Merged
Conversation
77f5f4a36 Updating GSL_SUPPRESS manually from the latest Microsoft code to fix compile errors seen when upgrading from "MSVC 19.44.35225.0" to "MSVC 19.51.36248.0" in github runner (#801) 02cc1095a Adjust warnings for GCC 15 (#800) ddc089486 Merge pull request #799 from holmesv3/compiler-compat da8d785bf Change to matches for clang compat b2f733b22 disable waf CI 8e45a80ac Make compatible with more compilers ed4d7b693 Ubuntu 24 build (#797) 939ecced8 Sync CODA-OSS with Projects that use expanded version (#796) 93e1231f6 Merge pull request #793 from mdaus/support/1.x 8af433cbf Merge pull request #792 from holmesv3/support/1.x 2cfe7e84e Merge branch 'support/1.x' into support/1.x 1fdb594d4 Add note about version scheme in README, setup CMake version info for find_package df7f96095 Add cmake module include 787418aed Add note about version scheme in README, setup CMake version info for find_package b2a0cbaab Add explicit implementations of polynomial velocity and acceleration (#791) git-subtree-dir: externals/coda-oss git-subtree-split: 77f5f4a363cd48cabbb82de61d8c5c564d9ef3c6
adam-beauchamp
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prefix assigned to each XML namespace is up to the document creator. SIX previously assumed that the prefix for the ISM namespace would always be "ism" and used this to construct queries into element attribute sets. These queries failed when the document creator used any other prefix.
This PR adds a function to retrieve the prefix from the XML document namespace list. This prefix is used to construct the queries into element attribute sets.