Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 132 additions & 0 deletions src/event.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
//! Helpers around nginx's event-loop globals.

#[cfg(ngx_feature = "stat_stub")]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this needs a feature gate, but ill defer to @bavshin-f5 or @ensh63 if either of them agree with having it.

@u5surf u5surf Aug 28, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avahahn
Thanks for the review — ②③④ are addressed in the force-pushed commit (rebased onto main, squashed per CONTRIBUTING).

On the gate: it's needed, but not as a Cargo feature — ngx_feature is the build-time cfg nginx-sys derives from nginx's own ngx_auto_config.h (NGX_STAT_STUBcargo::rustc-cfg=ngx_feature="stat_stub"). nginx declares these externs under #if (NGX_STAT_STUB) (src/event/ngx_event.h:468), so without stub_status bindgen emits nothing and the module doesn't compile:

error[E0432]: unresolved imports `crate::ffi::ngx_stat_accepted`,
`crate::ffi::ngx_stat_active`, `crate::ffi::ngx_stat_handled`,
`crate::ffi::ngx_stat_reading`, `crate::ffi::ngx_stat_requests`,
`crate::ffi::ngx_stat_waiting`, `crate::ffi::ngx_stat_writing`
error: could not compile `ngx` (lib) due to 1 previous error

(cargo build -p ngx --features vendored with the cfg attributes removed.)

Worth noting separately: NGINX_CONFIGURE_BASE has no --with-http_stub_status_module, so CI never compiles this path — I verified locally with NGX_CONFIGURE_ARGS="--with-http_stub_status_module" (tests + clippy pass with and without, nginx 1.30.4). Happy to add the flag here or leave it for a separate PR.

@bavshin-f5 @ensh63 — flagging in case you see it differently.

use crate::ffi::{
ngx_atomic_t, ngx_stat_accepted, ngx_stat_active, ngx_stat_handled, ngx_stat_reading,
ngx_stat_requests, ngx_stat_waiting, ngx_stat_writing,
};

/// One snapshot of nginx's global connection-state atomics — the
/// same values that the `ngx_http_stub_status_module` exposes.
///
/// The seven atomics are read independently, so the snapshot is
/// not consistent across counters; for monitoring use cases the
/// drift between reads is sub-microsecond and irrelevant.
#[cfg(ngx_feature = "stat_stub")]
#[derive(Clone, Copy, Debug, Default)]
#[non_exhaustive]
pub struct ConnectionStats {
/// Connections currently in use.
pub active: u64,
/// Connections currently reading a request header.
pub reading: u64,
/// Connections currently writing a response.
pub writing: u64,
/// Connections currently idle in keep-alive.
pub waiting: u64,
/// Total connections accepted since process start.
pub accepted: u64,
/// Total connections handled since process start.
pub handled: u64,
/// Total requests served since process start.
pub requests: u64,
}

/// Sample the global `ngx_stat_*` connection counters.
///
/// This is the programmatic equivalent of fetching the
/// `stub_status` response, suitable for plumbing into custom
/// exporters (Prometheus, statsd, etc.) without having to scrape
/// HTTP. Available only on nginx builds where
/// `ngx_http_stub_status_module` is compiled in.
#[cfg(ngx_feature = "stat_stub")]
pub fn connection_stats() -> ConnectionStats {
// SAFETY: the seven atomics are allocated and assigned by
// nginx core in the master process before workers fork, and
// are valid for the lifetime of the process. Each pointer is
// therefore stable to dereference once.
unsafe {
snapshot_from_ptrs(
ngx_stat_active,
ngx_stat_reading,
ngx_stat_writing,
ngx_stat_waiting,
ngx_stat_accepted,
ngx_stat_handled,
ngx_stat_requests,
)
}
}

/// Read the seven atomics through the supplied pointers. Exists
/// as its own function so unit tests can exercise the field
/// mapping with stack-allocated atomics, without depending on the
/// global `ngx_stat_*` symbols being resolvable in the test
/// binary.
///
/// # Safety
///
/// Every pointer must be valid for a non-volatile read of
/// `ngx_atomic_t`. The caller is responsible for upholding that
/// (in production callers always pass nginx-owned globals, which
/// satisfy the requirement by construction).
#[cfg(ngx_feature = "stat_stub")]
#[allow(clippy::unnecessary_cast)] // `ngx_atomic_t` is `c_ulong`, which is 32-bit on some targets.
unsafe fn snapshot_from_ptrs(
active: *const ngx_atomic_t,
reading: *const ngx_atomic_t,
writing: *const ngx_atomic_t,
waiting: *const ngx_atomic_t,
accepted: *const ngx_atomic_t,
handled: *const ngx_atomic_t,
requests: *const ngx_atomic_t,
) -> ConnectionStats {
unsafe {
ConnectionStats {
active: *active as u64,
reading: *reading as u64,
writing: *writing as u64,
waiting: *waiting as u64,
accepted: *accepted as u64,
handled: *handled as u64,
requests: *requests as u64,
}
}
}

#[cfg(all(test, ngx_feature = "stat_stub"))]
mod tests {
use super::*;

#[test]
fn snapshot_from_ptrs_maps_each_field() {
// Use distinct values so a field-to-field swap is caught.
let active: ngx_atomic_t = 7;
let reading: ngx_atomic_t = 1;
let writing: ngx_atomic_t = 2;
let waiting: ngx_atomic_t = 4;
let accepted: ngx_atomic_t = 100;
let handled: ngx_atomic_t = 99;
let requests: ngx_atomic_t = 250;

let s = unsafe {
snapshot_from_ptrs(
&raw const active,
&raw const reading,
&raw const writing,
&raw const waiting,
&raw const accepted,
&raw const handled,
&raw const requests,
)
};

assert_eq!(s.active, 7);
assert_eq!(s.reading, 1);
assert_eq!(s.writing, 2);
assert_eq!(s.waiting, 4);
assert_eq!(s.accepted, 100);
assert_eq!(s.handled, 99);
assert_eq!(s.requests, 250);
}
}
6 changes: 6 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,12 @@ pub mod collections;
/// utilities will generally align with the NGINX 'core' files and APIs.
pub mod core;

/// The event module.
///
/// Helpers around nginx's event-loop globals, currently the
/// `stub_status` connection-state atomics.
pub mod event;

/// The ffi module.
///
/// This module provides scoped FFI bindings for NGINX symbols.
Expand Down