Lua scenarios where configuration parsed incorrectly - #131
Draft
oliveromahony wants to merge 4 commits into
Draft
Conversation
xynicole
reviewed
Jan 22, 2025
Comment on lines
+324
to
+326
| {"{", 3}, | ||
| {"print(\"Test lua ssl certificate!\")", 4}, | ||
| {"}", 5}, |
Collaborator
There was a problem hiding this comment.
{"\n print(\"Test lua ssl certificate!\")\n ",5},
{";", 5},
We grab everything in the Lua block as a single token and drop the {}. Example:
content_by_lua_block {some code} will be content_by_lua_block "some code"; "some code" is an argument of directive.
For reference: #86
xynicole
reviewed
Jan 22, 2025
Comment on lines
+376
to
+378
| {"\n print(\"Test lua ssl certificate!\")\n ", 19}, | ||
| {")", 20}, | ||
| {"}", 21}, |
Collaborator
There was a problem hiding this comment.
Suggested change
| {"\n print(\"Test lua ssl certificate!\")\n ", 19}, | |
| {")", 20}, | |
| {"}", 21}, | |
| {"\n print(\"Test lua ssl certificate!\")\n ",21}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
An issue was discovered when parsing configurations with
ssl_certificate_by_lua_blockin them. This is intended to add a fix and tests covering those scenariosChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)