Skip to content

Add access token support - #71

Merged
route443 merged 3 commits into
nginxinc:mainfrom
nginx-openid-connect:021-access-token
Jan 9, 2023
Merged

Add access token support#71
route443 merged 3 commits into
nginxinc:mainfrom
nginx-openid-connect:021-access-token

Conversation

@shawnhankim

Copy link
Copy Markdown
Contributor

Issue:

Description:

  • Captured access_token in the NJS code.
  • Stored access_token in the key/value store as same as the NGINX RP stores id_token and refresh_token.

@shawnhankim

Copy link
Copy Markdown
Contributor Author

@route443 :

  • Thanks for your review in detail for the PR.
  • This PR is to simplify from the previous PR.
  • For you to easily manage this repo to reduce any concerns from the enhancements based on the reviews on the PR, I have divided a big PR into small PRs, and this is one of PRs.
  • Let me know if you have any questions.

@shawnhankim shawnhankim changed the title feat: added access token support feat: add access token support Dec 22, 2022

@route443 route443 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shawn. Thank you for your contribution to our nginx oidc project.
As I said in previous PRs, we are not using Conventional Commits for this project. So I wouldn't use this approach unnecessarily. Please change the commit name.

Comment thread README.md Outdated
Comment thread frontend.conf Outdated
Comment thread openid_connect_configuration.conf Outdated
Comment thread README.md
@shawnhankim shawnhankim changed the title feat: add access token support add access token support Dec 30, 2022
@shawnhankim

Copy link
Copy Markdown
Contributor Author

Hi Shawn. Thank you for your contribution to our nginx oidc project. As I said in previous PRs, we are not using Conventional Commits for this project. So I wouldn't use this approach unnecessarily. Please change the commit name.

Hi Ivan! Thank you so much for your time to review the PR in detail. I have addressed your comments as well as the new commit name. Please let me know if there is anything need to be changed. Happy New Year!

@shawnhankim
shawnhankim force-pushed the 021-access-token branch 2 times, most recently from df5d840 to 7817f3b Compare December 30, 2022 15:42
@shawnhankim shawnhankim changed the title add access token support Add access token support Dec 31, 2022
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated

@shawnhankim shawnhankim left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @route443 for your review. Revised them!

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@route443
route443 requested a review from a team January 6, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants