Skip to content

deploy: OAuth 로그인·계정 병합, 배치 스케줄러, 이메일 발송 rate limit 반영 - #39

Merged
SRIOUSS merged 34 commits into
dev-deployfrom
dev
Aug 13, 2026
Merged

deploy: OAuth 로그인·계정 병합, 배치 스케줄러, 이메일 발송 rate limit 반영#39
SRIOUSS merged 34 commits into
dev-deployfrom
dev

Conversation

@Jungeunsun565

Copy link
Copy Markdown
Contributor

🔀 PR 개요

  • dev에 반영된 기능들을 dev-deploy(배포)로 병합합니다.
  • GitHub OAuth 로그인, 배치 스케줄러(휴면 전환/하드 삭제), Redisson 분산 락 전환,
  • 이메일 발송 rate limit, CI 안정화 등이 포함됩니다.

📄 변경 사항

어떤 부분이 수정/추가/삭제되었는지 구체적으로 기술해 주세요.

  • 새로운 기능 추가 (✨ Feature)
  • 버그 수정 (🐞 BugFix)
  • 코드 리팩토링 (🔧 Refactor)
  • 문서 수정 (📝 Docs)
  • 테스트 코드 추가 (🧪 Test)
  • 배포 관련 (🚀 Deploy)
  • 기타 설정 변경 (🧰 Setting)

주요 변경 내용

✨ 기능

  • GitHub OAuth 로그인 추가 (provider별 클라이언트 분리, OauthClientResolver)
  • 배치 스케줄러 — 탈퇴 90일 경과 하드 삭제, 30일 미접속 휴면 전환
  • 이메일 발송 재전송 rate limit (연타 방지 + 횟수 제한 + 잠금)
  • 비밀번호 재설정 계정 열거 방지 및 토큰 역방향 키(예전 링크 무효화)

🔧 리팩토링

  • 스케줄러 분산 락을 Redisson RLock으로 전환 (워치독 + 소유권 확인 해제)
  • Service 조회 메서드 readOnly 트랜잭션 적용
  • HeaderAuthenticationFilter X-User-Role 헤더 처리

🐞 버그 수정

  • OAuth 신규 로그인 시 이메일 중복 처리 (existsByEmail, 검증된 primary 이메일 사용)
  • Resilience4j Circuit Breaker 설정 수정 (configs.default 적용)
  • 로그인 시 refresh 토큰 쿠키 발급

🧪 테스트

  • User, UserCredential, UserRole, Oauth, Repository 테스트 추가

🧰 설정

  • Redisson 의존성 버전 조정, Redis 접속 설정 수정
  • Dockerfile 수정

💡 변경 이유

dev에서 검증된 기능들을 배포 환경(dev-deploy)에 반영하기 위함입니다.


🧩 관련 이슈


🧪 테스트 방법

변경 내용을 확인할 수 있는 방법을 단계별로 설명해 주세요.
코드 블록(```)으로 콘솔 로그나 테스트 코드 결과를 첨부해도 좋습니다.

예시:

# 로컬 서버 실행
npm run dev
# 또는
python manage.py runserver

Jungeunsun565 and others added 30 commits August 6, 2026 21:38
feat: GitHub OAuth 로그인 추가 및 트랜잭션 리팩토링

- GitHub/Google OAuth 로그인 구현
- 트랜잭션 처리 리팩토링
- 불필요한 이메일 주소 제거
- FeignClient 어노테이션 수정
refactor: 전역 예외 처리 및 응답 구조 리팩토링
fix: Feign Circuit Breaker ID의 하이픈 제거 방지 설정 추가
…r-filter

refactor: HeaderAuthenticationFilter X-User-Role 헤더 사용
test: User, UserCredential, UserRole, Oauth 엔티티 테스트 작성
…gration

feat: application.properties dev/prod 분리 및 k8s 배포 환경 구성
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jungeunsun565, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e3c02608-c8c0-4103-984b-9d6c6e06d212

📥 Commits

Reviewing files that changed from the base of the PR and between b970af9 and dfca160.

📒 Files selected for processing (91)
  • Dockerfile
  • pom.xml
  • src/main/java/com/nhnacademy/insightonauth/InsightonAuthApplication.java
  • src/main/java/com/nhnacademy/insightonauth/client/CoreClient.java
  • src/main/java/com/nhnacademy/insightonauth/client/OauthClient.java
  • src/main/java/com/nhnacademy/insightonauth/client/OauthClientResolver.java
  • src/main/java/com/nhnacademy/insightonauth/client/impl/GithubOauthClient.java
  • src/main/java/com/nhnacademy/insightonauth/client/impl/GoogleOauthClient.java
  • src/main/java/com/nhnacademy/insightonauth/controller/AdminController.java
  • src/main/java/com/nhnacademy/insightonauth/controller/CoreController.java
  • src/main/java/com/nhnacademy/insightonauth/controller/MypageController.java
  • src/main/java/com/nhnacademy/insightonauth/controller/UserController.java
  • src/main/java/com/nhnacademy/insightonauth/dto/ApiResponse.java
  • src/main/java/com/nhnacademy/insightonauth/dto/ErrorResponse.java
  • src/main/java/com/nhnacademy/insightonauth/dto/core/AuthUserResponse.java
  • src/main/java/com/nhnacademy/insightonauth/dto/core/ManagerGroupExistsResponse.java
  • src/main/java/com/nhnacademy/insightonauth/email/EmailService.java
  • src/main/java/com/nhnacademy/insightonauth/entity/Oauth.java
  • src/main/java/com/nhnacademy/insightonauth/entity/User.java
  • src/main/java/com/nhnacademy/insightonauth/exception/BusinessException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/CoreServiceUnavailableException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/DuplicateEmailException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/DuplicatePhoneNumberException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/EmailAlreadyRegisteredException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/EmailNotFoundException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/EmailSendException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/ErrorCode.java
  • src/main/java/com/nhnacademy/insightonauth/exception/ErrorResponse.java
  • src/main/java/com/nhnacademy/insightonauth/exception/InvalidCredentialsException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/InvalidMergeRequestException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/InvalidReactiveTokenException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/InvalidRefreshTokenException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/InvalidUserException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/InvalidUserStatusException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/InvalidVerificationCodeException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/InvalidVerificationTokenException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/LastLoginMethodException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/LoginTemporarilyLockedException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/ManagerGroupExistsException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/OauthAlreadyLinkedException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/OauthConflictResponse.java
  • src/main/java/com/nhnacademy/insightonauth/exception/OauthLinkedToOtherAccountException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/OauthNotFoundException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/PasswordResetResendLockedException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/PasswordResetResendTooSoonException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/RefreshTokenNotFoundException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/RestorePeriodExpiredException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/UnsupportedOAuthProviderException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/UserCredentialsNotFoundException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/UserNotFoundException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/UserRoleNotFoundException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/VerificationResendLockedException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/VerificationResendTooSoonException.java
  • src/main/java/com/nhnacademy/insightonauth/exception/VerificationTemporarilyLockedException.java
  • src/main/java/com/nhnacademy/insightonauth/filter/HeaderAuthenticationFilter.java
  • src/main/java/com/nhnacademy/insightonauth/handler/GlobalExceptionHandler.java
  • src/main/java/com/nhnacademy/insightonauth/redis/RedisKey.java
  • src/main/java/com/nhnacademy/insightonauth/redis/RedisService.java
  • src/main/java/com/nhnacademy/insightonauth/repository/UserRepository.java
  • src/main/java/com/nhnacademy/insightonauth/scheduler/UserHardDeleteScheduler.java
  • src/main/java/com/nhnacademy/insightonauth/scheduler/UserSleepConversionScheduler.java
  • src/main/java/com/nhnacademy/insightonauth/service/MyPageService.java
  • src/main/java/com/nhnacademy/insightonauth/service/UserService.java
  • src/main/java/com/nhnacademy/insightonauth/service/impl/MyPageServiceImpl.java
  • src/main/java/com/nhnacademy/insightonauth/service/impl/OauthServiceImpl.java
  • src/main/java/com/nhnacademy/insightonauth/service/impl/UserCredentialServiceImpl.java
  • src/main/java/com/nhnacademy/insightonauth/service/impl/UserRoleServiceImpl.java
  • src/main/java/com/nhnacademy/insightonauth/service/impl/UserServiceImpl.java
  • src/main/resources/application-auth1.properties
  • src/main/resources/application-auth2.properties
  • src/main/resources/application-dev.properties
  • src/main/resources/application-prod.properties
  • src/main/resources/application.properties
  • src/main/resources/config/dev/actuator.properties
  • src/main/resources/config/dev/db.properties
  • src/main/resources/config/dev/mail.properties
  • src/main/resources/config/dev/redis.properties
  • src/main/resources/config/prod/actuator.properties
  • src/main/resources/config/prod/db.properties
  • src/main/resources/config/prod/mail.properties
  • src/main/resources/config/prod/redis.properties
  • src/test/java/com/nhnacademy/insightonauth/InsightonAuthApplicationTest.java
  • src/test/java/com/nhnacademy/insightonauth/entity/OauthTest.java
  • src/test/java/com/nhnacademy/insightonauth/entity/UserCredentialTest.java
  • src/test/java/com/nhnacademy/insightonauth/entity/UserRoleTest.java
  • src/test/java/com/nhnacademy/insightonauth/entity/UserTest.java
  • src/test/java/com/nhnacademy/insightonauth/repository/OauthRepositoryTest.java
  • src/test/java/com/nhnacademy/insightonauth/repository/UserCredentialRepositoryTest.java
  • src/test/java/com/nhnacademy/insightonauth/repository/UserRepositoryTest.java
  • src/test/java/com/nhnacademy/insightonauth/repository/UserRoleRepositoryTest.java
  • src/test/resources/application.properties

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SRIOUSS
SRIOUSS merged commit 58c8b9b into dev-deploy Aug 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants