Pull request for benjimons-develop branch.#3078
Closed
benjimons wants to merge 2 commits intonicolargo:benjimons-developfrom
Closed
Pull request for benjimons-develop branch.#3078benjimons wants to merge 2 commits intonicolargo:benjimons-developfrom
benjimons wants to merge 2 commits intonicolargo:benjimons-developfrom
Conversation
1. More memory efficiency 2. Added warning for file not faout 3. Condensed headers.
Owner
|
Hi @benjimons for Windows OS i think (hope) that the only think to do is take into account the carrier return. It is '\n' on Linux but '\r\n' on Windows. |
Author
|
@nicolargo maybe that should do it for the windows compatibility? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your feedback and kind support - here is my changes against #3071
Disable by default maybe we can leave to the last bit.
I am not sure what to do about Windows - this is supposed to be a plain file reader so I dont know what else to do - i dont really want to get into reading event log files.
On the WebUI side of things I am a bit lost.
Description
Changes
Resume