Skip to content

Refactor programlist _msg_curse_header to reduce cyclomatic complexity#3476

Open
wavebyrd wants to merge 6039 commits intonicolargo:developfrom
wavebyrd:reduce-complexity-programlist-header
Open

Refactor programlist _msg_curse_header to reduce cyclomatic complexity#3476
wavebyrd wants to merge 6039 commits intonicolargo:developfrom
wavebyrd:reduce-complexity-programlist-header

Conversation

@wavebyrd
Copy link
Copy Markdown

Summary

  • Extracted _msg_curse_header_cpu, _msg_curse_header_io, and _msg_curse_header_command helper methods from _msg_curse_header in the programlist plugin
  • Leveraged the existing msg_curse_header_common from the parent ProcesslistPlugin for simple sortable columns (memory_percent, username, num_threads, nice, status)
  • Reduced cyclomatic complexity of _msg_curse_header from 27 to 7

No behavioral changes. All extracted helpers preserve the original logic exactly.

Relates to #3460

drake7707 and others added 30 commits December 15, 2025 07:57
Include GTT to mem% for integrated AMD GPUs
License classifiers have been superseded by license expressions (see https://peps.python.org/pep-0639/).
Detailed changes:
- Enable autoescape=True for Jinja2 environment to prevent XSS (B701).
- Add timeout=15s to requests.get in nginx amp (B113).
- Add timeout=15s to post in restful export (B113).
…ty-bandit

fix(security): resolve B701 (Jinja2) and B113 (timeout) vulnerabilities
Update license specification to SPDX format
Fix quicklook in case psutil.cpu_freq().max=0.0
nicolargo and others added 28 commits March 4, 2026 16:15
Added installation instructions for Glances using UVx.
…hub.com:sdoshi2061/glances into sdoshi2061-mem-plugin_e8a559ce-ab5b-4674-91e2-9c4f42636da2
Unauthenticated Configuration Secrets Exposure
SQL Injection via Process Names in TimescaleDB Export
Updated security patch descriptions with correct CVE identifiers.
@wavebyrd wavebyrd force-pushed the reduce-complexity-programlist-header branch from 8f746f8 to e58f37c Compare March 13, 2026 21:23
@nicolargo
Copy link
Copy Markdown
Owner

Sorry @wavebyrd but i can not review a PR with more than 600 files modified (perhaps a format/lint issue in your dev environment (https://github.com/nicolargo/glances/wiki/How-to-contribute-to-Glances-%3F).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.