refactor(main): reduce cyclomatic complexity of init_plugins#3478
Open
wavebyrd wants to merge 6039 commits intonicolargo:developfrom
Open
refactor(main): reduce cyclomatic complexity of init_plugins#3478wavebyrd wants to merge 6039 commits intonicolargo:developfrom
wavebyrd wants to merge 6039 commits intonicolargo:developfrom
Conversation
Include GTT to mem% for integrated AMD GPUs
Using the format specified in: https://spdx.org/licenses/
License classifiers have been superseded by license expressions (see https://peps.python.org/pep-0639/).
Detailed changes: - Enable autoescape=True for Jinja2 environment to prevent XSS (B701). - Add timeout=15s to requests.get in nginx amp (B113). - Add timeout=15s to post in restful export (B113).
…ty-bandit fix(security): resolve B701 (Jinja2) and B113 (timeout) vulnerabilities
Update license specification to SPDX format
Fix quicklook in case psutil.cpu_freq().max=0.0
…hub.com:sdoshi2061/glances into sdoshi2061-mem-plugin_e8a559ce-ab5b-4674-91e2-9c4f42636da2
…da2' into develop
Unauthenticated Configuration Secrets Exposure
SQL Injection via Process Names in TimescaleDB Export
Updated security patch descriptions with correct CVE identifiers.
Extract four focused helper methods from init_plugins to bring its cyclomatic complexity from 19 down to 1: - _apply_config_disables: disable plugins listed in glances.conf - _apply_plugin_overrides: handle --disable-plugin/--enable-plugin CLI args - _activate_exporters: activate exporters from --export CLI arg - _apply_process_defaults: handle processcount/processlist dependencies and default export_process_filter Part of nicolargo#3460.
wavebyrd
force-pushed
the
reduce-complexity-init-plugins
branch
from
1e2fd2e to
560d73a
Compare
Author
|
Ping on this refactor to reduce cyclomatic complexity. Ready for review! |
Owner
|
Sorry @wavebyrd but i can not review a PR with more than 600 files modified (perhaps a format/lint issue in your dev environment (https://github.com/nicolargo/glances/wiki/How-to-contribute-to-Glances-%3F). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
init_pluginsinglances/main.pyto reduce its cyclomatic complexity from 19 to 1_apply_config_disables: disables plugins listed inglances.conf_apply_plugin_overrides: handles--disable-plugin/--enable-pluginCLI arguments (including theallkeyword)_activate_exporters: activates exporters from--export_apply_process_defaults: handles processcount/processlist dependencies and the defaultexport_process_filterPart of #3460.
Test plan
ruff checkandruff format --checkpass (confirmed locally)radon ccreports init_plugins at complexity A(1), all helpers under B(10)