fix: copy cached attachment in chunks via shutil.copyfileobj#252
Open
Flerpharos wants to merge 1 commit into
Open
fix: copy cached attachment in chunks via shutil.copyfileobj#252Flerpharos wants to merge 1 commit into
Flerpharos wants to merge 1 commit into
Conversation
get_attachment(use_tempfile=True) called self._filedata.read() with no size argument, materializing the entire cached payload as one bytes object before writing it to the output tempfile. This defeats the memory-saving purpose of use_tempfile=True for large attachments. Replace with shutil.copyfileobj which copies in bounded chunks (default 64 KB). Closes #215
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_attachment(use_tempfile=True)calledself._filedata.read()with no size argument, materializing the entire cached payload as onebytesobject before writing it to the output tempfile. This defeats the memory-saving purpose ofuse_tempfile=Truefor large attachments.Fix
Replace
output.write(self._filedata.read())withshutil.copyfileobj(self._filedata, output), which copies in bounded chunks (default 64 KB).Closes #215